Skip to content

Refacto config files#1663

Open
ga-devfront wants to merge 64 commits intoPrestaShop:devfrom
ga-devfront:refacto/config-files
Open

Refacto config files#1663
ga-devfront wants to merge 64 commits intoPrestaShop:devfrom
ga-devfront:refacto/config-files

Conversation

@ga-devfront
Copy link
Contributor

@ga-devfront ga-devfront commented Feb 13, 2026

Questions Answers
Description? It splits and renames the configurations specific to each process (update, backup, restore). This also makes performance fields configurable (only via CLI). Overall, this brings more clarity to the project and prevents unnecessarily loading configurations for a single variable that has nothing to do with the process.
Type? refactor
BC breaks? yes
Deprecations? no
Fixed ticket? N/A
Sponsor company @PrestaShopCorp
How to test? We have to test all process from CLI (with and without config file) and UI !

@ga-devfront ga-devfront added this to the 8.0.0 milestone Feb 13, 2026
@ga-devfront ga-devfront added the _🥬🍅🧅_ Type: All label Feb 16, 2026
@github-project-automation github-project-automation bot moved this to Ready for review in PR Dashboard Feb 16, 2026
@ga-devfront ga-devfront added the refacto Type: Refactoring label Feb 16, 2026
@ga-devfront ga-devfront marked this pull request as ready for review February 19, 2026 16:51
M0rgan01
M0rgan01 previously approved these changes Feb 23, 2026
Copy link
Contributor

@M0rgan01 M0rgan01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good for me, I'm waiting for the opinion of @Quetzacoalt91

@Quetzacoalt91
Copy link
Member

@ga-devfront What do you think about this tree?

$ tree classes/Parameters/
classes/Parameters/
├── Configuration
│   ├── AbstractConfiguration.php
│   ├── BackupConfiguration.php
│   ├── LanguageConfiguration.php
│   ├── Loader
│   │   ├── AbstractConfigurationLoader.php
│   │   ├── BackupConfigurationLoader.php
│   │   ├── RestoreConfigurationLoader.php
│   │   └── UpdateConfigurationLoader.php
│   ├── RestoreConfiguration.php
│   ├── UpdateConfiguration.php
│   └── Validator
│       ├── AbstractConfigurationValidator.php
│       ├── BackupConfigurationValidator.php
│       ├── LocalChannelConfigurationValidator.php
│       ├── RestoreConfigurationValidator.php
│       └── UpdateConfigurationValidator.php
├── ConfigurationStorage.php
├── FileStorage.php
├── index.php
└── UpgradeFileNames.php

Quetzacoalt91
Quetzacoalt91 previously approved these changes Feb 26, 2026
Quetzacoalt91
Quetzacoalt91 previously approved these changes Feb 26, 2026
Quetzacoalt91
Quetzacoalt91 previously approved these changes Mar 6, 2026
@ga-devfront ga-devfront force-pushed the refacto/config-files branch from cf8d6f6 to b32f3ba Compare March 13, 2026 09:17
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

_🥬🍅🧅_ Type: All refacto Type: Refactoring

Projects

Status: Ready for review

Development

Successfully merging this pull request may close these issues.

6 participants