Fix inline stylesheet rendering with nofilter#1047
Merged
Conversation
Double quotes in the CSS code are converted to " and single quotes are converted to ' so the CSS code on the page doesn't work.
Contributor
Author
Contributor
Author
|
in the file javascript.tpl is already present |
tblivet
approved these changes
Jun 17, 2026
ingridusta
approved these changes
Jun 17, 2026
2 tasks
Contributor
Author
|
Hi @tblivet |
Contributor
|
Hi @Maofree, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


NOTE: @ingridusta here is a module to perform tests 🙂
inlinecsstest.zip
$this->context->controller->registerStylesheet(
'modules-'.$this->name.'-hide-alias',
'/modules/'.$this->name.'/views/css/hide-alias.css',
['media' => 'all', 'priority' => 151, 'inline' => true]
);
then go into the source code of the front part of a page and see what code comes out