Fix coupon clicks #683
Open
Fix coupon clicks #683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tswfi
commented
Mar 12, 2025
•
tswfi
commented
| Questions | Answers |
|---|---|
| Description? | Fix problems with multiple highlighted coupon codes. Only the first highlighted coupon would work. Also fix multiple clicks on the coupon so that it does not toggle the input field. And fix problem when the input field was open already that clicking on highlighted coupon would close it again. Make remove coupon a post (next step would be to make it ajax call, but the current handleCartAction is not generic enough) |
| Type? | bug fix |
| BC breaks? | maybe? (link changed to form) |
| Deprecations? | no |
| Fixed ticket? | Fixes #684 |
| Sponsor company | Your company or customer's name goes here (if applicable). |
| How to test? | Prereqs: Add two cart coupons that are highlighted. View cart. Adding multiple coupons: Click on one coupon, the input field shows up, click apply, click on the next coupon. The click should work and the input field prefilled. Removing click on the trash button on the coupon line, the url should stay as "action=show" and no token is in the url and the coupon is removed. |
|
Unit tests are broken? |
tswfi
force-pushed
the
fix_coupon_clicks
branch
from
eda5556 to
b24e2a0
Compare
|
rebased to get unit tests working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.