feat: add employee resource#155
Open
fox-john wants to merge 6 commits into
Open
Conversation
|
Hello @fox-john! This is your first pull request on ps_apiresources repository of the PrestaShop project. Thank you, and welcome to this Open Source community! |
jolelievre
requested changes
Mar 12, 2026
| CQRSQueryMapping: self::QUERY_MAPPING, | ||
| CQRSCommandMapping: self::COMMAND_MAPPING, | ||
| ), | ||
| new CQRSPartialUpdate( |
Contributor
There was a problem hiding this comment.
The handler doesn't handle partial update so you shoud use a CQRSUpdate here instead
It uses the PUT word indicating you must provide the whole JSON, not partial fields
| operations: [ | ||
| new PaginatedList( | ||
| uriTemplate: '/employees', | ||
| provider: QueryListProvider::class, |
Contributor
There was a problem hiding this comment.
No need this is the default value with PaginatedList
jolelievre
reviewed
Mar 12, 2026
| { | ||
| $itemsCount = $this->countItems('/employees', ['employee_read']); | ||
|
|
||
| $employee = $this->requestApi('POST', '/employees', null, ['employee_write'], Response::HTTP_CREATED); |
Contributor
There was a problem hiding this comment.
Please use createItem (same for other tests, prefer the explicit help for the appropaite action)
Contributor
|
@fox-john CI is red, could you have a look please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.