Fix auto installing ps-modules #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ls: cannot access '/ps-modules/*.zip': No such file or directory
Remove .zip extension from the name
Usually zip archive will be module_name-1.7-0.2.zip not module_name.zip The real module name should be taken from the directory inside
|
FYI: @jokesterfr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version has 3 issues when using the "ps-modules" directory to auto-install modules:
`ls: cannot access '/ps-modules/*.zip': No such file or directory despite the fact that files are there
In the current implementation
basename ${file}doesn't strip the zip extension properly and the module cannot be installed.If you put a downloaded module zip that doesn't have an archive name like "modulename.zip", it won't work. Usually, they have ps versions, and module versions in the file name. The real name is inside.
After changes from this PR, it started working properly for me.