Fix loss_batch=0 indentation to run for all local ranks#5
Open
vominh1919 wants to merge 1 commit into
Open
Conversation
Move loss_batch=0 outside the if local_rank==0 block so that all local ranks reset it after the accumulated inner step, not just rank 0. Fixes PrimeIntellect-ai#4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4
loss_batch = 0was inside theif local_rank == 0:block (indent level 16), so only rank 0 was resetting it after the accumulated inner step. This moves it outside theifblock (indent level 12) so all local ranks resetloss_batchafter each accumulated inner step.Fixes #4