Skip to content

Pccl base #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion configs/debug/diloco.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ micro_bs = 8
[optim]
batch_size = 16
warmup_steps = 10
total_steps = 4
total_steps = 128

[data]
fake = true
Expand Down
2 changes: 1 addition & 1 deletion configs/debug/normal.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ micro_bs = 8
[optim]
batch_size = 16
warmup_steps = 10
total_steps = 4
total_steps = 128

[data]
fake = true
Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ dependencies = [
"psutil",
"torch-shampoo @ git+https://github.com/facebookresearch/optimizers.git@main",
"liger-kernel-nightly>=0.5.2.dev20250122195349",
"pccl @ git+https://github.com/PrimeIntellect-ai/pccl.git@main#subdirectory=python/framework"
]

[project.optional-dependencies]
Expand Down
69 changes: 0 additions & 69 deletions scripts/all_reduce.py

This file was deleted.

2 changes: 1 addition & 1 deletion scripts/simulate_multi_node_diloco.sh
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export GLOO_SOCKET_IFNAME=lo
for i in $(seq 0 $(($N - 1 )))
do
> logs/log$i.log
WANDB_MODE=$([ $i -eq 0 ] && echo "online" || echo "offline") GLOBAL_UNIQUE_ID=$i GLOBAL_RANK=$i CUDA_VISIBLE_DEVICES=$(get_cuda_devices $NUM_GPU $i) uv run torchrun --nproc_per_node=$NUM_GPU --node-rank 0 --rdzv-endpoint localhost:$((BASE_PORT + $i)) --nnodes=1 $@ --data.data_rank $i --data.data_world_size $N > logs/log$i.log 2>&1 &
WANDB_MODE=$([ $i -eq 0 ] && echo "online" || echo "offline") GLOBAL_UNIQUE_ID=$i GLOBAL_RANK=$i CUDA_VISIBLE_DEVICES=$(get_cuda_devices $NUM_GPU $i) OMP_NUM_THREADS=1 PCCL_LOG_LEVEL=DEBUG uv run torchrun --nproc_per_node=$NUM_GPU --node-rank 0 --rdzv-endpoint localhost:$((BASE_PORT + $i)) --nnodes=1 $@ --data.data_rank $i --data.data_world_size $N > logs/log$i.log 2>&1 &
child_pids+=($!)
done

Expand Down
4 changes: 2 additions & 2 deletions scripts/skip_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

from zeroband.data import get_dataloader

from zeroband.utils.world_info import get_world_info
from zeroband.utils.world_info import get_local_world_info
from zeroband.utils.logger import get_logger


Expand Down Expand Up @@ -79,7 +79,7 @@ def skip_data(config: Config):
if __name__ == "__main__":
torch.manual_seed(42)

world_info = get_world_info()
world_info = get_local_world_info()
logger = get_logger()

config = Config(**parse_argv())
Expand Down
Empty file removed src/zeroband/C/__init__.py
Empty file.
35 changes: 0 additions & 35 deletions src/zeroband/C/collectives.py

This file was deleted.

46 changes: 0 additions & 46 deletions src/zeroband/C/compression.py

This file was deleted.

Loading
Loading