Pccl integration #241
Open
Pccl integration #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsja
reviewed
Apr 9, 2025
Comment on lines
-2
to
-5
|
|
||
| set -e | ||
|
|
||
| # Colors for output |
samsja
reviewed
Apr 9, 2025
samsja
reviewed
Apr 10, 2025
| @@ -31,3 +42,46 @@ def set_optimizer_lr(optimizer: torch.optim.Optimizer, lr: float): | |||
| """ | |||
| for param_group in optimizer.param_groups: | |||
| param_group['lr'] = lr | |||
|
|
|||
|
|
|||
| OptimT = TypeVar("OptimT", bound=torch.optim.Optimizer) | |||
There was a problem hiding this comment.
Suggested change
| OptimT = TypeVar("OptimT", bound=torch.optim.Optimizer) | |
| OptimT : TypAlias = TypeVar("OptimT", bound=torch.optim.Optimizer) |
samsja
reviewed
Apr 10, 2025
| :param optimizer_type the type of optimizer used. | ||
| """ | ||
|
|
||
| def _validate_exists(to_check: List[Tuple[str, Optional[torch.Tensor]]]): |
There was a problem hiding this comment.
Suggested change
| def _validate_exists(to_check: List[Tuple[str, Optional[torch.Tensor]]]): | |
| def _validate_exists(to_check: list[tuple[str, torch.Tensor | None]]): |
samsja
reviewed
Apr 10, 2025
Comment on lines
+23
to
+30
| hf_name="mistralai/Mistral-7B-v0.1", | ||
| # print(len(AutoTokenizer.from_pretrained("mistralai/Mistral-7B-v0.1", use_fast=True))) | ||
| vocab_size=32000, | ||
| # print(AutoTokenizer.from_pretrained("mistralai/Mistral-7B-v0.1", use_fast=True).bos_token_id) | ||
| bot_token=1, | ||
| # print(AutoTokenizer.from_pretrained("mistralai/Mistral-7B-v0.1", use_fast=True).eos_token_id) | ||
| eot_token=2, | ||
| ) |
samsja
reviewed
Apr 10, 2025
Comment on lines
+32
to
+40
| return TokenizerInfo( | ||
| hf_name="meta-llama/Meta-Llama-3-8B", | ||
| # print(len(AutoTokenizer.from_pretrained("meta-llama/Meta-Llama-3-8B", use_fast=True))) | ||
| vocab_size=128256, | ||
| # print(AutoTokenizer.from_pretrained("mistralai/Mistral-7B-v0.1", use_fast=True).bos_token_id) | ||
| bot_token=128000, | ||
| # print(AutoTokenizer.from_pretrained("meta-llama/Meta-Llama-3-8B", use_fast=True).eos_token_id) | ||
| eot_token=128001, | ||
| ) |
There was a problem hiding this comment.
do we not want to tell people how to re-obtain this number easily?
samsja
reviewed
Apr 10, 2025
Comment on lines
-1
to
-16
| import copy | ||
| import torch | ||
| from zeroband.data import InterleaveDataset, ParquetDataset, SequencePackingDataSet, collate_fn | ||
| from torch.utils.data import DataLoader | ||
| from zeroband.data import load_all_datasets, DataConfig | ||
| from zeroband.utils.logger import get_logger | ||
| from collections import Counter | ||
| from itertools import chain | ||
| import pytest | ||
| import logging | ||
| import pyarrow as pa | ||
| import pyarrow.parquet as pq | ||
| from faker import Faker | ||
| from typing import List | ||
| import string | ||
| from torchdata.stateful_dataloader import StatefulDataLoader |
There was a problem hiding this comment.
why removing the sequence packing tests ?
There was a problem hiding this comment.
need to re-add them, but they were incompatible post port.
samsja
reviewed
Apr 10, 2025
Comment on lines
+231
to
+233
|
|
||
| if __name__ == '__main__': | ||
| pytest.main() |
samsja
reviewed
Apr 10, 2025
samsja
reviewed
Apr 10, 2025
samsja
reviewed
Apr 10, 2025
samsja
reviewed
Apr 10, 2025
samsja
reviewed
Apr 10, 2025
samsja
reviewed
Apr 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft, not ready to merge yet.