Skip to content

feat(StakeManager): rebonding, make staking more robust #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mattdf merged 4 commits into from
Jul 2, 2025
Merged

feat(StakeManager): rebonding, make staking more robust #60

mattdf merged 4 commits into from
Jul 2, 2025

Conversation

@mattdf
Copy link
Contributor

@mattdf mattdf commented Jun 30, 2025

No description provided.

@mattdf mattdf requested a review from manveerxyz June 30, 2025 12:48
manveerxyz
manveerxyz reviewed Jun 30, 2025
View reviewed changes
Copy link
Member

@manveerxyz manveerxyz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo it would be worth adding tests for this new functionality as well

@mattdf
Copy link
Contributor Author

mattdf commented Jul 2, 2025

imo it would be worth adding tests for this new functionality as well

Added module level tests in StakeManger.t.sol since it's pretty complex functionality at this point.

@mattdf mattdf requested a review from manveerxyz July 2, 2025 21:51
@mattdf mattdf merged commit f70d4db into main Jul 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manveerxyz manveerxyz manveerxyz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mattdf @manveerxyz