The initial folia support commit#11
The initial folia support commit#11Hihelloy-main wants to merge 37 commits intoPrimordialMoros:masterfrom
Conversation
Changed the plugin's base code to be folia compatible (with some small errors)
|
While I appreciate the effort to create this pull request, ProjectKorra itself is not Folia compatible, it is not thread safe, it has global state everywhere and changing a couple schedulers won't fix that. You have also made several questionable changes such as breaking compatibility with previous versions and platforms, adding unused utils, lowered the minimum java version from 21 to 17 etc. I can also see two decompiled classes in the utils. If you want to update the pr, you can bump some dependencies and cleanup some of the deprecated api usage instead. |
This is simply a pre release but I will do that! |
…is used (it now goes away when you use the move again)
…rion into Folia-Support
…rion into Folia-Support
Re-adds spigot support (via the FoliaScheduler library). Removes support for mc 1.20.1 and lower. Strengthens Paper support. Adds extra debug messages. Adds and utilizes the PaperLib util (meant to strengthen paper/spigot/luminol/folia compatibility). Maintains Jitpack support. Downgrades the RainbowParticleEffect to use the spigot particle builder (needed for proper spigot support). Edits the ThreadUtil.
…rion into Folia-Support
Copies but reworks ProjectKorra's ThreadUtil (now works with Hyperion's schedulers and will be used in Hyperion 1.7.5)
…ed ProjectKorra API. Use the Adventure API instead of the Bungee API. Bump Adventure
….12.0-. Don't divide the duration of a potion effect by 50 as that is already done in the PotionEffectAdapter implmentations.
2 participants
Changed the plugin's base code to be folia compatible (with some small errors)