fix(bedrock/proto): mismatched field type in TransactionActions#1157
Open
hax0r31337 wants to merge 4 commits intoPrismarineJS:masterfrom
Open
fix(bedrock/proto): mismatched field type in TransactionActions#1157hax0r31337 wants to merge 4 commits intoPrismarineJS:masterfrom
hax0r31337 wants to merge 4 commits intoPrismarineJS:masterfrom
Conversation
Author
|
🤦 I totally forgot i8 is signed int when i created this pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inventory_id should be zigzag32 instead of varint
https://github.com/CloudburstMC/Nukkit/blob/master/src/main/java/cn/nukkit/network/protocol/types/NetworkInventoryAction.java#L74
I have also removed the unreachable negative enum entries on
WindowIDVarinttype as varint type are serialized as unsigned