-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Bedrock connection & chat support #3539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected] |
would be great to make progress on this |
|
||
const isBedrock = options.version ? options.version.includes(BEDROCK_PREFIX) : false | ||
const isBedrockSpecificVersion = isBedrock ? options.version.includes(BEDROCK_VERSION_PREFIX) : false | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rom1504, @extremeheat have you considered using consistent bedrock version naming in all PrismarineJS libraries? It would be less messy if bedrock version names always started with the bedrock_ prefix. ex minecraft-data requires prefix, bedrock-protocol requires version without prefix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It already is consistent, because the versions in the loaders are in the end passed down to minecraft-data which has the prefix handling. The only place that allows without the prefix is bedrock-protocol, where the version has a different meaning.
TODO: