fix: fix entities leak on world switch, add worldSwitch event#3624
Closed
zardoy wants to merge 3 commits intoPrismarineJS:masterfrom
Closed
fix: fix entities leak on world switch, add worldSwitch event#3624zardoy wants to merge 3 commits intoPrismarineJS:masterfrom
zardoy wants to merge 3 commits intoPrismarineJS:masterfrom
Conversation
Member
|
Please add a test, see pending PR in switch world |
Contributor
Author
That pr seems reliable enough for me, do you have any suggestion? Should I remove it here? |
Member
|
Either finish the initial PR so the feature work including passing tests or do not use this feature yes |
Contributor
Author
Ok, not a problem. I'll remove the event emitting then (since I'm not aware of the issues of that pr and I don't really need it) |
Contributor
Author
|
I have no idea how to finish it, should I close it? |
Member
|
Yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emit removing the entity before actually removing it from the list (when clearing the object)