Use minecraft-protocol zlib fix for Node 24#3878
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
962dccd to
449b56d
Compare
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
449b56d to
78de66e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Node's async zlib creates C++ handles that can error after JS listeners are removed during teardown. Known Node.js issues:
Performance (no slowdown)
Within noise — no measurable difference.
See PrismarineJS/node-minecraft-protocol#1476
🤖 Generated with Claude Code