Skip to content

Use minecraft-protocol zlib fix for Node 24#3878

Merged
rom1504 merged 1 commit intomasterfrom
update-nmp-zlib-fix
Apr 1, 2026
Merged

Use minecraft-protocol zlib fix for Node 24#3878
rom1504 merged 1 commit intomasterfrom
update-nmp-zlib-fix

Conversation

@rom1504
Copy link
Copy Markdown
Member

@rom1504 rom1504 commented Mar 31, 2026

Summary

  • Point minecraft-protocol to PrismarineJS/node-minecraft-protocol#fix-zlib-node24
  • Fixes uncaught zlib errors from async zlib C++ race condition during client disconnect
  • Temporary until NMP publishes a new release

Why

Node's async zlib creates C++ handles that can error after JS listeners are removed during teardown. Known Node.js issues:

Performance (no slowdown)

Job group Master (async) PR (sync)
Avg across all groups 256s 259s

Within noise — no measurable difference.

See PrismarineJS/node-minecraft-protocol#1476

🤖 Generated with Claude Code

@socket-security
Copy link
Copy Markdown

socket-security Bot commented Mar 31, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedprismarine-provider-anvil@​2.13.07610010089100
Addedgh-helpers@​1.2.0761008182100
Addedmineflayer-pathfinder@​1.10.08910010080100
Addedmineflayer-pathfinder@​2.4.58910010080100

View full report

@rom1504 rom1504 force-pushed the update-nmp-zlib-fix branch 3 times, most recently from 962dccd to 449b56d Compare April 1, 2026 03:30
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@rom1504 rom1504 force-pushed the update-nmp-zlib-fix branch from 449b56d to 78de66e Compare April 1, 2026 04:30
@rom1504 rom1504 merged commit dc5c91a into master Apr 1, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant