Fix/issue 1835#1836
Open
shankumar7 wants to merge 2 commits into
Open
Conversation
|
@shankumar7 is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed widespread E2E test failures caused by a missing
NEXTAUTH_SECRETenvironment variable in the Next.js Edge Runtime when running Playwright in standalone mode.Closes #1835
Type of Change
Changes Made
.github/workflows/e2e.ymlto explicitly create a.env.productionfile during the CI pipeline.NEXTAUTH_SECRETand other required OS environment variables into the build process so they are correctly passed to the Next.js Edge middleware sandbox.How to Test
Steps for the reviewer to verify this works:
E2E / Playwright smoke testsworkflow.settings page saves and reflects changes) now pass successfully.Screenshots (if UI change)
N/A
Checklist
npm run lintpasses locallynpm run type-check)Accessibility Checklist
Additional Notes
Next.js
standalonemode does not automatically inherit OS-level environment variables in the Edge runtime. Generating.env.productionensures the variables are bundled and accessible tomiddleware.tsfor JWT decryption.