Skip to content

Conversation

DenuxPlays
Copy link
Collaborator

@DenuxPlays DenuxPlays commented Aug 31, 2025

  • Update to rust edition 2024
  • bump msrv to 1.85.0

Closes: #55

@DenuxPlays DenuxPlays self-assigned this Aug 31, 2025
@DenuxPlays
Copy link
Collaborator Author

@ProbablyClem Not sure if we want the msrv bump to 1.85.0

But I guess that people how do not want to update can still use the 0.3.0-alpha.2 release or what do you say?

@DenuxPlays
Copy link
Collaborator Author

This is also my last goal for the 0.3.0 "stable" release since I see no way to fix #36 for now

@ProbablyClem
Copy link
Owner

It's a bit unfortunate to update the msrv because we don't really use any of the newer rust features...
But if it's the only way to fix the rust-analyzer bug I guess it's OK as long as we document it somewhere (In the release note should be enough)

But if it's a rust-analyzer does the msrv really have an impact? Is it not a minimum rust-analyzer version that we need instead?

As always thanks for your work

@DenuxPlays
Copy link
Collaborator Author

Oh no

We dont fix any rust analyzer features with it. (sadly)
This is just to keep utoipauto up to date nothing else.

This is just something I had on my to do list for version 0.3.0

@ProbablyClem
Copy link
Owner

The minimum supported rust version should be as low as possible.
The lower it is, the more projects can use it.

It's not a matter of being up to date,
we should increase the msrv only if we really need a new rust feature.

If we upgrade to 1.85, it will prevent projets in 1.75 from using for no reason

There's even projects to find the lowest msrv possible (ie. https://gribnau.dev/cargo-msrv)

I don't really think we need to care that much about it but we should not increase it without the need for it

@DenuxPlays
Copy link
Collaborator Author

Alright 👍

Then we should keep in mind that when we increase the msrv it would make sense to increase it to 1.85.0 so that we can update our edition.

Until then I'll leave this pr open if that's ok

@DenuxPlays DenuxPlays marked this pull request as draft August 31, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update rust edition to 2024

2 participants