Code Review: User grouping RBAC #44
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham-atoms
commented
Jul 23, 2025
| UserGroup group = findGroupById(roleAssignmentDto.getGroupId()); | ||
|
|
||
| // BUG 1: No validation for empty role collections - unnecessary processing | ||
| for (Long roleId : roleAssignmentDto.getRoleIds()) { |
There was a problem hiding this comment.
No validation for empty role collections - unnecessary processing
| .filter(group -> !group.isDeleted()) | ||
| .forEach(group -> { | ||
| // Extra unnecessary database call for each group | ||
| UserGroup refreshedGroup = userGroupRepository.findById(group.getId()).orElse(group); |
There was a problem hiding this comment.
Performance issue - unnecessary database calls in loop
|
|
||
| public boolean hasPermission(Long userId, String permission) { | ||
| // BUG 2: Incorrect logic - should check if user has permission, not if they don't | ||
| return !getAllPermissionsForUser(userId).contains(permission); |
There was a problem hiding this comment.
Incorrect logic - should check if user has permission, not if they don't
| .deleted(group.isDeleted()) | ||
| .deletedAt(group.getDeletedAt()) | ||
| // BUG 3: Data integrity issue - including deleted members/roles in counts | ||
| .memberIds(group.getMembers().stream() |
There was a problem hiding this comment.
Data integrity issue - including deleted members/roles in counts
|
|
||
| public void addMember(Account account) { | ||
| // BUG 4: Missing null check - will cause NullPointerException | ||
| this.members.add(account); |
There was a problem hiding this comment.
Missing null check - will cause NullPointerException
| public void removeMember(Account account) { | ||
| // BUG 7: Memory leak - only removing from one side of bidirectional relationship | ||
| this.members.remove(account); | ||
| // account.getUserGroups().remove(this); // Commented out - causes memory leak |
There was a problem hiding this comment.
Memory leak - only removing from one side of bidirectional relationship
| UserGroup existingGroup = findGroupById(groupId); | ||
|
|
||
| // BUG 6: Case sensitivity bug - allows duplicate names with different cases | ||
| if (!existingGroup.getName().equals(groupDto.getName()) && |
There was a problem hiding this comment.
Case sensitivity bug - allows duplicate names with different cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code Review: User grouping RBAC