Add MW 44 support and drop support for MW below 43#76
Conversation
📝 WalkthroughWalkthroughThe CI workflow was updated to include MediaWiki version REL1_44 with PHP 8.4 in the PHPUnit test matrix. Multiple import statements in source and test files were changed to use fully qualified namespaces for classes such as Parser, Html, Title, User, ContentHandler, and ParserOutput. No logic or functionality was altered. Changes
Possibly related PRs
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
JeroenDeDauw
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
README.md (2)
100-105: Unordered-list style is inconsistent → triggers MD004The project uses
-for lists earlier in the document (e.g. L15-19), while these new items switch to*.
Pick one style and stick to it:-* [PHP] 8.0 or later (tested up to 8.4) -* [MediaWiki] 1.43 or later (tested up to 1.44 and master) +- [PHP] 8.0 or later (tested up to 8.4) +- [MediaWiki] 1.43 or later (tested up to 1.44 and master)(or convert the earlier dashes to asterisks).
This clears the MD004 warnings and keeps the README tidy.
249-255: Release-notes list style mismatchThe bullet list here repeats the
*vs-inconsistency flagged above.
Update for uniform style to keep markdown-lint happy:-* Raised minimum MediaWiki version from 1.39 to 1.43 -* Added support for MediaWiki 1.44 -* Fixed compatibility issue with the Network extension -* Translation updates +- Raised minimum MediaWiki version from 1.39 to 1.43 +- Added support for MediaWiki 1.44 +- Fixed compatibility issue with the Network extension +- Translation updates
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (13)
.github/workflows/ci.yml(1 hunks)README.md(2 hunks)extension.json(2 hunks)src/Adapters/EmbedPresenter/CategoryUsageTracker.php(1 hunks)src/Adapters/EmbedPresenter/ParserFunctionEmbedPresenter.php(1 hunks)src/Adapters/EmbedResourceLoader/ParserFunctionEmbedResourceLoader.php(1 hunks)src/Domain/ContentRenderer/CodeRenderer.php(2 hunks)src/EntryPoints/BitbucketFunction.php(1 hunks)src/EntryPoints/EmbedFunction.php(1 hunks)src/EntryPoints/MediaWikiHooks.php(1 hunks)tests/Integration/EmbedFunctionIntegrationTest.php(2 hunks)tests/Integration/EmbedFunctionSystemTest.php(1 hunks)tests/TestEnvironment.php(1 hunks)
✅ Files skipped from review due to trivial changes (4)
- extension.json
- src/Domain/ContentRenderer/CodeRenderer.php
- src/Adapters/EmbedResourceLoader/ParserFunctionEmbedResourceLoader.php
- src/EntryPoints/MediaWikiHooks.php
🚧 Files skipped from review as they are similar to previous changes (6)
- tests/Integration/EmbedFunctionSystemTest.php
- tests/TestEnvironment.php
- src/Adapters/EmbedPresenter/CategoryUsageTracker.php
- src/Adapters/EmbedPresenter/ParserFunctionEmbedPresenter.php
- tests/Integration/EmbedFunctionIntegrationTest.php
- .github/workflows/ci.yml
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
README.md
102-102: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
103-103: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
251-251: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
252-252: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
253-253: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
254-254: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
🔇 Additional comments (3)
README.md (1)
113-113: Ensure the new Composer constraint is actually available
professional-wiki/external-content:~4.0assumes a4.0.0tag is on Packagist/Git.
Double-check that the tag will be pushed before merging, and thatextension.jsonalready advertises4.0.0(looks correct).
Otherwise users following the README will get a version-resolution error.src/EntryPoints/BitbucketFunction.php (1)
7-7: LGTM! Namespace clarification for MediaWiki 1.44 compatibility.The import statement update from
use Parser;touse MediaWiki\Parser\Parser;is a proper namespace clarification that aligns with MediaWiki 1.44's class organization. This change maintains functionality while ensuring compatibility with the newer MediaWiki version.src/EntryPoints/EmbedFunction.php (1)
7-7: LGTM! Consistent namespace clarification across the codebase.The import statement update matches the change in
BitbucketFunction.php, ensuring consistent use of the fully qualifiedMediaWiki\Parser\Parsernamespace. This maintains consistency across the codebase while supporting MediaWiki 1.44 compatibility.
|
Parser tests need fixing due to different output on MW 43 and MW 44. Perhaps we just run them on 44+? |
It is caused by HTML change from Codex message box. We can just create a separate parser test for 1.44+ to cover that. |
|
@alistair3149 can you fix this? Easiest approach is fine, as long as it runs on MW 44 and above. Skipping 43 is acceptable |
2 participants
Summary by CodeRabbit