Drop compat code for pre-MW-36

[JeroenDeDauw]

Summary by CodeRabbit

• Refactor
  • Streamlined how user context is resolved during wikitext rendering by removing legacy fallback logic. This simplifies control flow and maintenance with no impact on normal behavior. Input handling and output formatting remain unchanged, with no user-facing settings or performance differences. Overall, this is an internal cleanup aligned with current platform capabilities. No action required for users.

[coderabbitai]

📝 Walkthrough

Walkthrough

WikitextParser::wikitextToHtml now unconditionally calls getUserIdentity() when constructing ParserOptions, removing the previous method_exists check and fallback to getUser(). All other behavior remains the same, including empty input handling, parse invocation, and returning getText().

Changes

Cohort / File(s)	Summary
Parser identity retrieval simplification src/Presentation/WikitextParser.php	Removed method_exists check and fallback to getUser(); now always uses getUserIdentity() to build ParserOptions. No other logic changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch rmcompat

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/Presentation/WikitextParser.php (1)

23-27: Optional: add a brief inline note about dropped pre-MW-1.36 compat

Tiny doc hint to future maintainers can save time when reading blame/PR title in isolation.

 		return $this->parser->parse(
 			$text,
 			$this->parser->getTitle(),
-			new ParserOptions( $this->parser->getUserIdentity() )
+			// Requires MW ≥ 1.36 (Parser::getUserIdentity())
+			new ParserOptions( $this->parser->getUserIdentity() )
 		)->getText();

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 958b64d and d9d8e30.

📒 Files selected for processing (1)

• src/Presentation/WikitextParser.php (1 hunks)

🔇 Additional comments (2)

src/Presentation/WikitextParser.php (2)

26-26: Compat removal to MW ≥ 1.36 looks correct

Unconditionally using $this->parser->getUserIdentity() aligns with dropping pre-MW-1.36 compatibility. The rest of the call chain remains unchanged and appropriate.

---

26-26: No action required — MediaWiki requirement >=1.36 satisfied & no compat fallbacks found

• extension.json declares: ">= 1.40.0" — satisfies the >= 1.36 requirement.
• No remaining method_exists(...getUserIdentity) compatibility checks were found.
• The only ParserOptions usage is in src/Presentation/WikitextParser.php (lines ~26–28):
  • new ParserOptions( $this->parser->getUserIdentity() )