Reject NeoWikiSubject as a page main content model#1108
Merged
Conversation
`SubjectContentHandler` inherited the permissive default `canBeUsedOn()`, which
returns true for any title. Because MediaWiki grants `editcontentmodel` to
logged-in users by default, a user could set an arbitrary page's main content
model to `NeoWikiSubject`, producing an orphan page that is not projected to the
graph and renders blank.
`NeoWikiSubject` is only ever valid inside the dedicated subject slot ("neo"),
whose content model is fixed by its slot role via `defineRoleWithModel`. That
slot role compares the model directly and never consults `canBeUsedOn`, so
overriding it to return false locks the model out of every main-content-model
path (the content-model change UI, the edit API, page moves, and imports)
without affecting subject slot writes.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
JeroenDeDauw
marked this pull request as ready for review
July 20, 2026 20:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SubjectContentHandlerinherited the permissive defaultcanBeUsedOn(), whichreturns true for any title. Because MediaWiki grants
editcontentmodeltologged-in users by default, a user could set an arbitrary page's main content
model to
NeoWikiSubject, producing an orphan page that is not projected to thegraph and renders blank.
NeoWikiSubjectis only ever valid inside the dedicated subject slot ("neo"),whose content model is fixed by its slot role via
defineRoleWithModel. Thatslot role compares the model directly and never consults
canBeUsedOn, sooverriding it to return false locks the model out of every main-content-model
path (the content-model change UI, the edit API, page moves, and imports)
without affecting subject slot writes.