Only show edit schema button to authorized users in SubjectEditorDialog#428
Merged
Conversation
alistair3149
marked this pull request as ready for review
January 20, 2026 22:27
alistair3149
force-pushed
the
followup-369
branch
from
January 20, 2026 22:28
c76691c to
e43adc8
Compare
alistair3149
changed the title
alistair3149
commented
Jan 20, 2026
| try { | ||
| canEditSchema.value = await NeoWikiServices.getSchemaAuthorizer().canEditSchema( props.subject.getSchemaName() ); | ||
| } catch ( error ) { | ||
| console.error( 'Failed to check schema permissions:', error ); |
Member
Author
There was a problem hiding this comment.
For the error handling, should we aim for consistency (i.e., logging to both the console and notifications) or be situational?
In this case, I think that the schema edit permission error isn't critical for the SubjectEditor, so I did not display the error as a notification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #369
Recording.2026-01-20.172700.mp4