This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Added past events header #47
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Added correct back link 2) import CSS style 3) h1 text for "PAST EVENTS"
Added necessary changes according to Figma design.
Import PastEventsHeader jsx file
✅ Deploy Preview for au-pclub ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolves #32.
Description
-This PR adds a "Past Events" header component
-Imports past events header in
PastEvets.jsx-Styles text alignment, color, and size according to Figma
Demo Past Events Page
Checklist
Please ensure the following before submitting the PR:
CODE_OF_CONDUCT.mdfile and followed it's guidlines.Additional Comments
Challenges
This is one of my first contributions to open-source projects. I struggled running my code locally to test my updates but learned a lot. Thanks for the opportunity.
Testing
Ran my code in Chrome and Safari Browser.
Comments
In the CSS file of the component,
past-events-headercan be modified with:height: 300px;change the height of the header accordingly to the page laterbackground-image: url('');add a URL to the actual figma design's background (I couldn’t find the image)