Skip to content

Implement plugin check action#164

Merged
ilicfilip merged 14 commits into
developfrom
jdv/plugin-check-action
Nov 14, 2025
Merged

Implement plugin check action#164
ilicfilip merged 14 commits into
developfrom
jdv/plugin-check-action

Conversation

@jdevalk

@jdevalk jdevalk commented Nov 13, 2025

Copy link
Copy Markdown
Member

No description provided.

@github-actions

github-actions Bot commented Nov 13, 2025

Copy link
Copy Markdown

Test on Playground
Test this pull request on the Playground
or download the zip

@jdevalk

jdevalk commented Nov 13, 2025

Copy link
Copy Markdown
Member Author

Please give the translations a good test too, as I removed the load_plugin_textdomain call.

@ilicfilip

Copy link
Copy Markdown
Contributor

For me translations are not working with or without the load_plugin_textdomain call.

Reason is that text domain is defined as comment-hacks, but that doesn't match the plugin slug which is yoast-comment-hacks. So the translations are downloaded from .org repo, but because of the mismatch they are not used. When I change search & replace text domain in the PHP files they are loaded fine.

@jdevalk

jdevalk commented Nov 14, 2025

Copy link
Copy Markdown
Member Author

Hmm ok, let's just do that then?

@jdevalk

jdevalk commented Nov 14, 2025

Copy link
Copy Markdown
Member Author

@ilicfilip can you test again?

@ilicfilip

Copy link
Copy Markdown
Contributor

@jdevalk , translations are loaded fine for me now.

@ilicfilip
ilicfilip merged commit 71e5a4a into develop Nov 14, 2025
13 checks passed
@ilicfilip
ilicfilip deleted the jdv/plugin-check-action branch November 14, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants