Add C# code coverage for ControlPanel pure-logic services - #12
Merged
chrisholloway5 merged 2 commits intoAug 7, 2026
Merged
Conversation
![code-coverage-agent[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
Co-authored-by: chrisholloway5 <43516439+chrisholloway5@users.noreply.github.com>
code-coverage-agent
AI
changed the title
Code Coverage OverviewLanguages: C# C# / code-coverage-agentThe overall coverage in commit 3b559a6 in the Show a code coverage summary of the most covered files.
|
chrisholloway5
deleted the
code-coverage-agent/setup-code-coverage-reporting
branch
August 7, 2026 05:12
chrisholloway5
added a commit
that referenced
this pull request
Aug 7, 2026
Version bump to 6.2.9 (build 11) across the server (Version.h), the Control Panel (ControlPanel.csproj) and the installer (section_setup_64.iss), plus README release notes. 6.2.9 completes what 6.2.8 deliberately left out. No server-core changes. - LiveCharts moves to 2.0.5 (#11). 6.2.8 pinned it to 2.0.0-rc2 because the upgrade painted the dashboard charts as an opaque white block over the dark theme. CartesianChart derives from Control and 2.0.x gives it a solid default Background where the release candidate left it unset; the charts now set it explicitly. The empty-state labels were never hidden - they were light-grey text on that white block. - The Control Panel gains its first automated tests (#12), plus a solution for the .NET 8 stack. Verified against a live 6.2.9 server: unit assertions, the offline CollectionEditorView harness, the live DomainDialog/ServerSession harness, the UI-automation pass, the dashboard render in both light and dark themes, and the new xUnit suite.
chrisholloway5
added a commit
that referenced
this pull request
Aug 7, 2026
Adds the repository's first automated test coverage for the Control Panel. A net8.0-windows ControlPanel.Core library exposes three side-effect-free services (PasswordStrength, NumericField, PasswordGenerator) via shared <Compile Include> links, so no code moves and the existing ControlPanel project is untouched. ControlPanel.Tests runs 17 xUnit tests against it with coverlet.collector emitting Cobertura XML, and CI gains additive steps to run them and publish the coverage report. Verified locally before merge: builds clean, 17/17 tests pass, the Control Panel itself still builds warning-free under -warnaserror, and the change merges without conflict against the 6.2.8 line.
chrisholloway5
added a commit
that referenced
this pull request
Aug 7, 2026
Version bump to 6.2.9 (build 11) across the server (Version.h), the Control Panel (ControlPanel.csproj) and the installer (section_setup_64.iss), plus README release notes. 6.2.9 completes what 6.2.8 deliberately left out. No server-core changes. - LiveCharts moves to 2.0.5 (#11). 6.2.8 pinned it to 2.0.0-rc2 because the upgrade painted the dashboard charts as an opaque white block over the dark theme. CartesianChart derives from Control and 2.0.x gives it a solid default Background where the release candidate left it unset; the charts now set it explicitly. The empty-state labels were never hidden - they were light-grey text on that white block. - The Control Panel gains its first automated tests (#12), plus a solution for the .NET 8 stack. Verified against a live 6.2.9 server: unit assertions, the offline CollectionEditorView harness, the live DomainDialog/ServerSession harness, the UI-automation pass, the dashboard render in both light and dark themes, and the new xUnit suite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repository had no test coverage infrastructure — CI only compiled the WPF ControlPanel without running any tests or generating coverage data.
Changes
ControlPanel.Coreclass library (hmailserver/source/Tools/ControlPanel.Core/)net8.0-windowslibrary project that exposes the three side-effect-free services via shared<Compile Include="…">links — no code moved or duplicated, existing ControlPanel project untouchedPasswordStrength,NumericField,PasswordGeneratorControlPanel.TestsxUnit project (hmailserver/source/Tools/ControlPanel.Tests/)ControlPanel.Core; usescoverlet.collectorfor native Cobertura XML outputnet8.0-windowsto match the CI runner (windows-latest)ci.yml— additive steps only, existing steps unchanged:--collect:"XPlat Code Coverage"+Format=coberturacoverage/coverage.cobertura.xmlupload-coverage-csharpjob (withcode-quality: write) downloads and callsactions/upload-code-coverage@v1.gitignore— coverage output,bin/, andobj/for both new projects addedCoverage report flow