Skip to content

Conversation

@ouyangluwei163
Copy link
Contributor

What type of PR is this?
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #991

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
nope

@hami-robott hami-robott bot added kind/bug Something isn't working dco-signoff: yes labels Apr 16, 2025
@hami-robott hami-robott bot requested review from chaunceyjiang and wawa0210 April 16, 2025 09:59
@hami-robott
Copy link
Contributor

hami-robott bot commented Apr 16, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ouyangluwei163
Once this PR has been reviewed and has the lgtm label, please assign archlitchi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hami-robott hami-robott bot added the size/S label Apr 16, 2025
@codecov
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 64.42% <100.00%> (+17.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/scheduler/score.go 96.50% <100.00%> (+26.00%) ⬆️

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@archlitchi
Copy link
Member

/lgtm

@archlitchi archlitchi merged commit 7ee5dce into Project-HAMi:master Apr 27, 2025
19 of 21 checks passed
@ouyangluwei163 ouyangluwei163 mentioned this pull request May 6, 2025
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vgpu-devices-allocated annotations are inconsistent

2 participants