Add nvidia gpu topoloy score registry to node #1018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lengrongfu
force-pushed
the
feat/besteffort_policy
branch
2 times, most recently
from
99ab981 to
1fb2f31
Compare
Signed-off-by: rongfu.leng <[email protected]>
lengrongfu
force-pushed
the
feat/besteffort_policy
branch
from
1fb2f31 to
83fa3fd
Compare
Codecov ReportAttention: Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 14 files with indirect coverage changes 🚀 New features to boost your workflow:
|
yxxhero
reviewed
Apr 19, 2025
| @@ -185,8 +187,25 @@ func (plugin *NvidiaDevicePlugin) RegistrInAnnotation() error { | |||
| return err | |||
| } | |||
| encodeddevices := util.EncodeNodeDevices(*devices) | |||
| var data []byte | |||
| if os.Getenv("ENABLE_TOPOLOGY_SCORE") == "true" { | |||
There was a problem hiding this comment.
creating const for ENABLE_TOPOLOGY_SCORE will better?
|
I'd like to work on #822 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #822
Special notes for your reviewer:
Does this PR introduce a user-facing change?: