Skip to content

feat: Support for using RuntimeClass with nvidia devices #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

chinaran
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

  1. helm values.yaml adds the devicePlugin.createRuntimeClass parameter, which allows you to choose whether or not to create the corresponding RuntimeClass resource if the user sets the parameter devicePlugin.runtimeClassName.
  2. After the hami-schedule webhook determines that the pod is using nvidia resources, it will set the pod.Spec.RuntimeClassName according to the runtimeClassName parameter if the user has not set it.

Benefits:

image

Does this PR introduce a user-facing change?:

No.

Copy link

codecov bot commented Apr 24, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/device/nvidia/device.go 50.00% 7 Missing and 2 partials ⚠️
Flag Coverage Δ
unittests 64.81% <50.00%> (+17.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/device/nvidia/device.go 35.82% <50.00%> (-1.95%) ⬇️

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant