-
Notifications
You must be signed in to change notification settings - Fork 313
feat: vxpu sopport #1016 #1102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: vxpu sopport #1016 #1102
Conversation
Signed-off-by: ouyangluwei(riseunion) <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ouyangluwei163 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: ouyangluwei(riseunion) <[email protected]>
Signed-off-by: ouyangluwei(riseunion) <[email protected]>
Signed-off-by: ouyangluwei(riseunion) <[email protected]>
Signed-off-by: ouyangluwei(riseunion) <[email protected]>
Signed-off-by: ouyangluwei(riseunion) <[email protected]>
Codecov ReportAttention: Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
memnum = int(m) | ||
} | ||
} | ||
cores := memnum * 100 / 98304 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This cores percentage and memory is same, Is there any special reason? can't a similar setup as Nvidia vgpu be achieved?
} | ||
|
||
func (dev *Devices) trimMemory(m int64) int64 { | ||
temps := []int64{24576, 49152} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this because xpu can only achieve three slicing specifications: 1, 1/2 and 1/4?
/hold This PR can be put on hold. The maintainer team is refactoring the scheduling code for different GPUs and the basic support for Kunlun. We can review this PR after the update. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1016
Special notes for your reviewer:
Does this PR introduce a user-facing change?: