Skip to content

feat: vxpu sopport #1016 #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ouyangluwei163
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #1016

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Signed-off-by: ouyangluwei(riseunion) <[email protected]>
Copy link
Contributor

hami-robott bot commented Jun 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ouyangluwei163
Once this PR has been reviewed and has the lgtm label, please assign wawa0210 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hami-robott hami-robott bot added the size/L label Jun 4, 2025
ouyangluwei(riseunion) added 5 commits June 4, 2025 19:30
Signed-off-by: ouyangluwei(riseunion) <[email protected]>
Signed-off-by: ouyangluwei(riseunion) <[email protected]>
Signed-off-by: ouyangluwei(riseunion) <[email protected]>
Signed-off-by: ouyangluwei(riseunion) <[email protected]>
Signed-off-by: ouyangluwei(riseunion) <[email protected]>
Copy link

codecov bot commented Jun 5, 2025

Codecov Report

Attention: Patch coverage is 27.05882% with 124 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/device/kunlunxin/device.go 24.37% 118 Missing and 3 partials ⚠️
pkg/device/devices.go 70.00% 2 Missing and 1 partial ⚠️
Flag Coverage Δ
unittests 61.82% <27.05%> (-1.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/device/devices.go 73.53% <70.00%> (-0.12%) ⬇️
pkg/device/kunlunxin/device.go 24.37% <24.37%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

memnum = int(m)
}
}
cores := memnum * 100 / 98304
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cores percentage and memory is same, Is there any special reason? can't a similar setup as Nvidia vgpu be achieved?

}

func (dev *Devices) trimMemory(m int64) int64 {
temps := []int64{24576, 49152}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this because xpu can only achieve three slicing specifications: 1, 1/2 and 1/4?

@wawa0210
Copy link
Member

wawa0210 commented Jun 7, 2025

/hold

This PR can be put on hold. The maintainer team is refactoring the scheduling code for different GPUs and the basic support for Kunlun. We can review this PR after the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

适配昆仑芯 P800
3 participants