Skip to content

Conversation

@DSFans2014
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

currently, resource quotas are validated in the hami-scheduler's Fit phase. If validation fails, the pod remains in Pending state. This behavior is inconsistent with Kubernetes' native validation.
However, some resources such as nvidia.com/gpumem-percentage can only be determined with specific values during the scheduling phase, and cannot be validated at the webhook stage

So we only check the fixed resource request such as nvidia.com/gpumem and nvidia.com/gpucores in webhook
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@hami-robot
Copy link
Contributor

hami-robot bot commented Jan 20, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DSFans2014
Once this PR has been reviewed and has the lgtm label, please assign archlitchi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hami-robot hami-robot bot requested review from FouoF and lengrongfu January 20, 2026 07:33
@hami-robot hami-robot bot added the size/L label Jan 20, 2026
@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

❌ Patch coverage is 77.77778% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/scheduler/webhook.go 77.77% 6 Missing and 2 partials ⚠️
Flag Coverage Δ
unittests 51.25% <77.77%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/scheduler/webhook.go 64.28% <77.77%> (+10.11%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant