feat: check resource quota in webhook #1605
Open
+209
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
currently, resource quotas are validated in the hami-scheduler's
Fitphase. If validation fails, the pod remains inPendingstate. This behavior is inconsistent with Kubernetes' native validation.However, some resources such as
nvidia.com/gpumem-percentagecan only be determined with specific values during the scheduling phase, and cannot be validated at the webhook stageSo we only check the fixed resource request such as
nvidia.com/gpumemandnvidia.com/gpucoresin webhookWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: