Skip to content

fix device typos #1608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hami-robot merged 2 commits into from
Jan 21, 2026
+18 −25
Merged

fix device typos #1608

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8a1e75
fix: fix device typos
DSFans2014 Jan 20, 2026
fd95197
fix: fix gemini comment
DSFans2014 Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pkg/device/enflame/device.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ type EnflameDevices struct {
const (
EnflameVGCUDevice = "Enflame"
EnflameVGCUCommonWord = "Enflame"
// IluvatarUseUUID is user can use specify Iluvatar device for set Iluvatar UUID.
// EnflameUseUUID is user can use specify Enflame device for set Enflame UUID.
EnflameUseUUID = "enflame.com/use-gpuuuid"
// IluvatarNoUseUUID is user can not use specify Iluvatar device for set Iluvatar UUID.
// EnflameNoUseUUID is user can not use specify Enflame device for set Enflame UUID.
EnflameNoUseUUID = "enflame.com/nouse-gpuuuid"
PodRequestGCUSize = "enflame.com/gcu-request-size"
PodAssignedGCUID = "enflame.com/gcu-assigned-id"
Expand Down Expand Up @@ -164,7 +164,7 @@ func (dev *EnflameDevices) checkType(annos map[string]string, d device.DeviceUsa
func (dev *EnflameDevices) checkUUID(annos map[string]string, d device.DeviceUsage) bool {
userUUID, ok := annos[EnflameUseUUID]
if ok {
klog.V(5).Infof("check uuid for Iluvatar user uuid [%s], device id is %s", userUUID, d.ID)
klog.V(5).Infof("check uuid for Enflame user uuid [%s], device id is %s", userUUID, d.ID)
// use , symbol to connect multiple uuid
for uuid := range strings.SplitSeq(userUUID, ",") {
if d.ID == uuid {
Expand All @@ -176,7 +176,7 @@ func (dev *EnflameDevices) checkUUID(annos map[string]string, d device.DeviceUsa

noUserUUID, ok := annos[EnflameNoUseUUID]
if ok {
klog.V(5).Infof("check uuid for Iluvatar not user uuid [%s], device id is %s", noUserUUID, d.ID)
klog.V(5).Infof("check uuid for Enflame not user uuid [%s], device id is %s", noUserUUID, d.ID)
// use , symbol to connect multiple uuid
for uuid := range strings.SplitSeq(noUserUUID, ",") {
if d.ID == uuid {
Expand Down
2 changes: 1 addition & 1 deletion pkg/device/mthreads/device.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ func (dev *MthreadsDevices) checkUUID(annos map[string]string, d device.DeviceUs

noUserUUID, ok := annos[MthreadsNoUseUUID]
if ok {
klog.V(5).Infof("check uuid for Iluvatar not user uuid [%s], device id is %s", noUserUUID, d.ID)
klog.V(5).Infof("check uuid for Mthreads not user uuid [%s], device id is %s", noUserUUID, d.ID)
// use , symbol to connect multiple uuid
noUserUUIDs := strings.Split(noUserUUID, ",")
return !slices.Contains(noUserUUIDs, d.ID)
Expand Down