fix(hack): write the coverage mode line and data to the same file - #2935
fix(hack): write the coverage mode line and data to the same file#2935im-Toqeer-506 wants to merge 1 commit into
Conversation
Signed-off-by: M Toqeer Zia <muhammadtoqeerzia586694@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: im-Toqeer-506 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe unit test script now writes the coverage mode line and merged profile data to ChangesCoverage Output Correction
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized change makes the coverage header and merged data use the same truncated file, correcting coverage reporting without affecting production behavior. No actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Linked Issues checkExplanation The changes satisfy issue Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes the coverage output in
hack/unit-test.sh.The script was writing the coverage header and data to different files. Because of this:
make testreported 0% coverage.mode:header.make testmultiple times appended duplicate coverage data.This PR writes the header and data to the same file and truncates the file before writing.
Which issue(s) this PR fixes:
Fixes #2933
AI assistance disclosure:
I used an AI assistant to verify the implementation and test cases. I reviewed the changes and validation results.
Hardware validation:
Not applicable. This change only affects test/coverage tooling and does not change production or device code.
Does this PR introduce a user-facing change?
AI assistance disclosure:
I used an AI assistant to verify the implementation and test cases. I reviewed the changes and validation results.
Summary by CodeRabbit