fix(ci): run the compile, chart and e2e jobs on merge - #2963
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mesutoezdil The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughThe CI workflow now runs build, chart packaging, and E2E jobs on ChangesMaster branch CI execution
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change enables the existing compile, chart, and end-to-end checks to run on merges to master while preserving pull-request behavior. No actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/kind bug |
5560887 to
f4a329b
Compare
The comments say these jobs execute when hami code merges, but they gate only on get_info.outputs.e2e_run. That value comes from git diff $(github.event.pull_request.base.sha) $(github.sha), and on a push the pull_request context is empty, so the diff compares against nothing and yields no files. The run for 95530c6 on master logs an empty PR commit and reports Compile, package_chart, e2e_test and e2e_mig_test as skipped. The test job already carries the master escape hatch. Give the remaining four the same one so the whole set agrees. Compile and package_chart run on ubuntu-22.04, so they are safe anywhere, but the two e2e jobs need the self-hosted nvidia runners, which only the upstream repository has. Their escape hatch is scoped with github.repository so a fork pushing to its own master does not queue a job that can never be picked up. The workflow is meant to run on forks, as its own header comment says. Pull requests are unaffected: github.ref is refs/pull/N/merge there, so a docs only change still skips everything it skipped before. Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
f4a329b to
5029836
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
1 participant
No description provided.