fix(chart): add standard labels to webhook, monitor role, and runtime class - #2985
fix(chart): add standard labels to webhook, monitor role, and runtime class#2985magic-peach wants to merge 1 commit into
Conversation
MutatingWebhookConfiguration, the device plugin monitor ClusterRole, and the RuntimeClass had no labels at all, unlike nearly every other resource in the chart including other cluster scoped ones. Missing this on the webhook config in particular makes it harder to find with label selector queries since it is the most operationally significant resource here. Signed-off-by: Akanksha Trehun <akankshatrehun@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: magic-peach The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe Helm templates add component-specific and shared chart labels to the device-plugin monitor ChangesHelm resource labeling
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Feature Merge Risk: ⚪ Minimal · up to This change adds consistent labels to the webhook, monitor ClusterRole, and RuntimeClass without changing their functional behavior. No current merge-readiness risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit tags each chart with care Comment |
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
MutatingWebhookConfiguration(charts/hami/templates/scheduler/webhook.yaml), the device plugin monitorClusterRole(charts/hami/templates/device-plugin/monitorrole.yaml), and theRuntimeClass(charts/hami/templates/device-plugin/runtime-class.yaml) had no labels at all, unlike nearly every other resource in the chart, including other cluster scoped ones like the scheduler ClusterRole and the device plugin ClusterRoleBinding. This adds the same standard labels those already have. The webhook config in particular is the most operationally significant resource in the chart, so missing labels there makes it harder to find with label selector based tooling.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Verified with
helm lintandhelm template --show-onlyon all three files: labels render correctly, no other output changed.Does this PR introduce a user-facing change?:
No behavior change; adds standard
app.kubernetes.io/*andhelm.sh/chartlabels to three resources that previously had none.This PR was written primarily by Claude Code, an AI assistant, under my direction and review. I verified the change with helm lint and helm template and reviewed the diff before submitting.
Summary by CodeRabbit