Skip to content

refactor: defer ReleaseNodeLock #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

refactor: defer ReleaseNodeLock #35

wants to merge 3 commits into from

Conversation

@DSFans2014
Copy link
Contributor

@DSFans2014 DSFans2014 commented Sep 26, 2025 •
edited
Loading

  • defer ReleaseNodeLock
  • print lockerr if call ReleaseNodeLock failed

@hami-robot hami-robot bot requested a review from archlitchi September 26, 2025 03:42
@hami-robot
Copy link

hami-robot bot commented Sep 26, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DSFans2014
Once this PR has been reviewed and has the lgtm label, please assign archlitchi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hami-robot hami-robot bot added the size/S label Sep 26, 2025
@DSFans2014 DSFans2014 changed the title fix: fix nil pod when call ReleaseNodeLock refactor: defer ReleaseNodeLock Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@archlitchi archlitchi Awaiting requested review from archlitchi

Assignees

No one assigned

Labels

dco-signoff: yes size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@DSFans2014