Skip to content

Conversation

@yuntianfeijing
Copy link

No description provided.

@hami-robot hami-robot bot requested a review from SataQiu August 28, 2025 09:18
@hami-robot hami-robot bot requested a review from william-wang August 28, 2025 09:18
@hami-robot
Copy link

hami-robot bot commented Aug 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yuntianfeijing
Once this PR has been reviewed and has the lgtm label, please assign sataqiu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hami-robot
Copy link

hami-robot bot commented Aug 28, 2025

Welcome @yuntianfeijing! It looks like this is your first PR to Project-HAMi/volcano-vgpu-device-plugin 🎉

}
for _, val := range dlist {
tmp += val.Id + "," + strconv.FormatInt(int64(val.Count), 10) + "," + strconv.Itoa(int(val.Devmem)) + "," + val.Type + "," + strconv.FormatBool(val.Health) + "," + val.Mode + ":"
tmp += val.Id + "," + strconv.FormatInt(int64(val.Count), 10) + "," + strconv.Itoa(int(val.Devmem)) + "," + core + "," + val.Type + "," + strconv.FormatBool(val.Health) + "," + val.Mode + ":"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The string format here needs to be modified very carefully. It should be modified in synchronization with the volcano-scheduler and keep compatible.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

volcano APPROVED the PR:
volcano-sh/volcano#4597

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants