Minor fixes for encoding and call of undefined methods#33
Open
che85 wants to merge 2 commits intoProject-MONAI:mainfrom
Open
Minor fixes for encoding and call of undefined methods#33che85 wants to merge 2 commits intoProject-MONAI:mainfrom
che85 wants to merge 2 commits intoProject-MONAI:mainfrom
Conversation
SachidanandAlle
approved these changes
Oct 12, 2023
Collaborator
SachidanandAlle
left a comment
There was a problem hiding this comment.
Looks good to me
Contributor
|
I was having issues without the encoding... #26 |
Author
|
@wyli That's odd. I tested without the encoding on MacOS and Redhat Linux and it works for me. |
|
Tested locally, and this makes the plugin usable in Linux. Tested with Slicer release 5.6.1. EDIT: Not really, cannot make it work with just LoadImaged, it crashes with no message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #32
fixes #30