-
Notifications
You must be signed in to change notification settings - Fork 61
Making MONAI Deploy app and MAP run as REST services on Aidoc AiOS #554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a lightweight Flask-based REST wrapper to run a MONAI Deploy app (AISpleenSeg) with status and callback support, plus scripts and docs to test locally.
- Introduces REST endpoints (/status, /process) that run the app in a background thread and optionally POST results to a callback URL
- Provides a sample AISpleenSeg app wired into the wrapper, including pipeline composition and result reporting
- Adds local test script and documentation for setup, data download, and endpoint testing
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| platforms/aidoc/restful_app/app.py | Flask REST server, job lifecycle handling, and callback dispatch. |
| platforms/aidoc/restful_app/ai_spleen_seg_app/app.py | AISpleenSeg app composition and result packaging for callback. |
| platforms/aidoc/restful_app/ai_spleen_seg_app/init.py | Package init for AISpleenSeg; alters sys.path. |
| platforms/aidoc/restful_app/ai_spleen_seg_app/main.py | Entrypoint to run AISpleenSeg standalone. |
| platforms/aidoc/restful_app/ai_spleen_seg_app/app.yaml | App metadata and resource hints. |
| platforms/aidoc/restful_app/requirements.txt | Wrapper runtime dependencies (Flask, requests, SDK, MONAI, Torch, etc.). |
| platforms/aidoc/restful_app/ai_spleen_seg_app/requirements.txt | App-specific dependencies; overlaps with wrapper requirements. |
| platforms/aidoc/restful_app/env_settings_repo.sh | Example environment variable settings (model/input/output). |
| platforms/aidoc/test_endpoints.sh | Script to test endpoints and capture callback via netcat. |
| platforms/aidoc/README.md | How-to run, test, and callback payload examples. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
38b22df to
6e63d95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested the test_endpoints.sh script and everything look good. Thanks!
Signed-off-by: M Q <[email protected]>
…1 release Signed-off-by: M Q <[email protected]>
Signed-off-by: M Q <[email protected]>
Signed-off-by: M Q <[email protected]>
Signed-off-by: M Q <[email protected]>
Signed-off-by: M Q <[email protected]>
Signed-off-by: M Q <[email protected]>
Signed-off-by: M Q <[email protected]>
Signed-off-by: M Q <[email protected]>
Signed-off-by: M Q <[email protected]>
Signed-off-by: M Q <[email protected]>
Signed-off-by: M Q <[email protected]>
Signed-off-by: M Q <[email protected]>
5d0d972 to
0bc3bf5
Compare
Signed-off-by: Elan Somasundaram <[email protected]> Signed-off-by: chezhia <[email protected]>
Signed-off-by: Elan Somasundaram <[email protected]> Signed-off-by: chezhia <[email protected]>
Signed-off-by: chezhia <[email protected]>
Signed-off-by: chezhia <[email protected]>
… of latest holoscan SDK CUDA 12 version (#565) * Make affine and space consistent as space is properly parse by MONAI transforms Signed-off-by: M Q <[email protected]> * Typing improvements Signed-off-by: M Q <[email protected]> * Make image metadata Affine and Space consistent, either LPS or RAS Signed-off-by: M Q <[email protected]> * Update monai/deploy/operators/monai_seg_inference_operator.py Co-authored-by: Copilot <[email protected]> Signed-off-by: Ming M Qin <[email protected]> * Correct CoPilot suggested code which failed liniting Signed-off-by: M Q <[email protected]> * Fix complaint from new version of mypy Signed-off-by: M Q <[email protected]> * Support the latest holoscan SDK CUDA 12 version, holoscan-cu12 Signed-off-by: M Q <[email protected]> * Docs gen works with Python 3.10+ Signed-off-by: M Q <[email protected]> * Fix complaints on single quote vs dhouble quote for string Signed-off-by: M Q <[email protected]> * Making docs gen require python >= 3.10 Signed-off-by: M Q <[email protected]> * Fix docs build error on readthedocs, although local builds had no issues Signed-off-by: M Q <[email protected]> --------- Signed-off-by: M Q <[email protected]> Signed-off-by: Ming M Qin <[email protected]> Co-authored-by: Copilot <[email protected]>
* Update release notes for v3.3.0 Signed-off-by: M Q <[email protected]> * Update the index file Signed-off-by: M Q <[email protected]> * Bump version: 3.2.0 → 3.3.0 Signed-off-by: M Q <[email protected]> --------- Signed-off-by: M Q <[email protected]>
Signed-off-by: M Q <[email protected]>
Signed-off-by: M Q <[email protected]>
|
|
SonarQubeCloud / SonarCloud Code Analysis Quality Gate failure can be ignored, because the example in this PR deliberately reuses the same example code to illustrate how to make it an REST service for Aidoc. |


Adds a lightweight Flask-based REST wrapper to run a MONAI Deploy app (AISpleenSeg) with status and callback support, plus scripts and docs to test locally.
docker runcommand for needing additional options such as volume mappings and environment variable passing.