Skip to content

Conversation

@neildsouth
Copy link
Member

Description

Adds a new plugin that simply saves files to local storage, intended for use where files as being stored on a NAS/SAN

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

@codecov
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

❌ Patch coverage is 79.63710% with 101 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.77755%. Comparing base (2361edd) to head (6565bd7).
⚠️ Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
...ugins/Simple/SimpleStorage/SimpleStorageService.cs 70.98765% 37 Missing and 10 partials ⚠️
...Plugins/Simple/SimpleStorage/HealthCheckBuilder.cs 0.00000% 12 Missing ⚠️
...rc/Plugins/Simple/Tests/Unit/SimpleStorageTests.cs 95.74468% 0 Missing and 12 partials ⚠️
...s/Simple/SimpleStorage/SimpleStorageHealthCheck.cs 0.00000% 9 Missing ⚠️
.../SimpleStorage/Exceptions/FileNotFoundException.cs 0.00000% 6 Missing ⚠️
src/Storage/API/VerifyObjectsException.cs 0.00000% 6 Missing ⚠️
...e/SimpleStorage/Exceptions/FileCorruptException.cs 33.33333% 4 Missing ⚠️
...lugins/Simple/SimpleStorage/ServiceRegistration.cs 0.00000% 3 Missing ⚠️
src/Storage/API/StorageConnectionException.cs 33.33333% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #303         +/-   ##
===================================================
+ Coverage   79.40979%   79.77755%   +0.36776%     
===================================================
  Files             38          47          +9     
  Lines           1491        1978        +487     
  Branches          78         123         +45     
===================================================
+ Hits            1184        1578        +394     
- Misses           268         339         +71     
- Partials          39          61         +22     
Flag Coverage Δ
unittests 79.77755% <79.63710%> (+0.36776%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../Plugins/Simple/SimpleStorage/ConfigurationKeys.cs 100.00000% <100.00000%> (ø)
src/Plugins/Simple/SimpleStorage/HashCreator.cs 100.00000% <100.00000%> (ø)
src/Storage/API/StorageConnectionException.cs 33.33333% <33.33333%> (ø)
...lugins/Simple/SimpleStorage/ServiceRegistration.cs 0.00000% <0.00000%> (ø)
...e/SimpleStorage/Exceptions/FileCorruptException.cs 33.33333% <33.33333%> (ø)
.../SimpleStorage/Exceptions/FileNotFoundException.cs 0.00000% <0.00000%> (ø)
src/Storage/API/VerifyObjectsException.cs 0.00000% <0.00000%> (ø)
...s/Simple/SimpleStorage/SimpleStorageHealthCheck.cs 0.00000% <0.00000%> (ø)
...Plugins/Simple/SimpleStorage/HealthCheckBuilder.cs 0.00000% <0.00000%> (ø)
...rc/Plugins/Simple/Tests/Unit/SimpleStorageTests.cs 95.74468% <95.74468%> (ø)
... and 1 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2361edd...6565bd7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Neil South <[email protected]>
Signed-off-by: Neil South <[email protected]>
Signed-off-by: Neil South <[email protected]>
Signed-off-by: Neil South <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants