Skip to content

demote trunk from divided highways to normal roads, anounce ramps whe… #4275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

MoKob
Copy link

@MoKob MoKob commented Jul 10, 2017

…n entering a motorway directly

Issue

resolves #4274

Tasklist

  • add regression / cucumber cases (see docs/testing.md)
  • review
  • adjust for comments

@TheMarex
Copy link
Member

How does this affect scenarios that use a trunk_link like this example? Do we emit a on ramp in this case, or would this become a turn right?

@MoKob
Copy link
Author

MoKob commented Jul 11, 2017

Sadly these would be labeled a simple turn. The problem is that we need a way to find out about these dual-carriage ways. We might be able to assign the motorway tag based on available references/country level.
While the linked example would surely be best described as a ramp, we have many other cases just like here osrm which surely aren't ramps :(

@TheMarex
Copy link
Member

I think the OSM tagging in the highway 101 case is actually wrong. This segment is clearly part of the normal traffic flow of the highway. For example this segment also just connects two trunk roads but is also tagged trunk.

We should first get a good understanding of what the trade-off here is. We might be improving instructions inside some US cities but seems like we could vastly decrease our guidance quality in other areas. Maybe the answer here can be to insist on better tagging on OSM side.

@MoKob
Copy link
Author

MoKob commented Jul 11, 2017

I think you are right and we should investigate further. It might be that we just need another level of country awareness, based on tagging schemes. I am tagging this as experimental and feature request for now.

@@ -62,7 +62,7 @@ bool MotorwayHandler::canProcess(const NodeID,
for (const auto &road : intersection)
{
// not merging or forking?
if (road.entry_allowed && angularDeviation(road.angle, STRAIGHT_ANGLE) > 60)
if (road.entry_allowed && angularDeviation(road.angle, STRAIGHT_ANGLE) > 91)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 91?!

@MoKob MoKob closed this Jan 22, 2018
@DennisOSRM DennisOSRM deleted the demote-trunk branch November 6, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Demote Trunk Roads to non-motorway type
3 participants