Skip to content

WIP: Parallel cucumbers #7309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MarcelloPerathoner wants to merge 19 commits into
base: master
Choose a base branch
from
+847 −1,011
Open

WIP: Parallel cucumbers #7309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
ef551b4
Initial commit
MarcelloPerathoner Dec 17, 2025
b54b525
add tests
MarcelloPerathoner Dec 17, 2025
52fcbed
Initial commit
MarcelloPerathoner Dec 18, 2025
289b871
Initial commit
MarcelloPerathoner Dec 18, 2025
fa8b21e
Merge pull request #9 from MarcelloPerathoner/Fix-issue-7299
MarcelloPerathoner Dec 19, 2025
43cd8c0
Merge pull request #11 from MarcelloPerathoner/CI-build-add-clang-19-20
MarcelloPerathoner Dec 19, 2025
10075b7
Merge pull request #8 from MarcelloPerathoner/Fix-issue-7296
MarcelloPerathoner Dec 19, 2025
abf733e
Fix cucumber routed startup timeout
MarcelloPerathoner Dec 20, 2025
67564f3
Fix npm install
MarcelloPerathoner Dec 20, 2025
eea7d7f
Fix build
MarcelloPerathoner Dec 20, 2025
1330112
fix ci build
MarcelloPerathoner Dec 20, 2025
a6c388e
fix ci build
MarcelloPerathoner Dec 20, 2025
1a6fb81
Use global env and cache. Remove lots of async craziness.
MarcelloPerathoner Dec 21, 2025
6b6c844
fix cache cleanup
MarcelloPerathoner Dec 22, 2025
f28b3cc
Refactor some more
MarcelloPerathoner Dec 22, 2025
0f8a8f0
Simplify env
MarcelloPerathoner Dec 22, 2025
8b768a8
Parallel cucumbers
MarcelloPerathoner Dec 23, 2025
af32067
fix logfile artifact
MarcelloPerathoner Dec 24, 2025
885fd76
fix expandOptions
MarcelloPerathoner Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
137 changes: 76 additions & 61 deletions .github/workflows/osrm-backend.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ jobs:

cmake -DCMAKE_BUILD_TYPE=Release -DENABLE_CONAN=ON -DENABLE_NODE_BINDINGS=ON ..
cmake --build . --config Release

# TODO: MSVC goes out of memory when building our tests
# - name: Run tests
# shell: bash
Expand Down Expand Up @@ -170,28 +170,25 @@ jobs:
strategy:
matrix:
include:
- name: gcc-13-debug-cov
- name: clang-20-release
continue-on-error: false
node: 22
runs-on: ubuntu-24.04
BUILD_TYPE: Debug
CCOMPILER: gcc-13
BUILD_TYPE: Release
CCOMPILER: clang-20
CXXCOMPILER: clang++-20
CUCUMBER_TIMEOUT: 20000
CXXCOMPILER: g++-13
ENABLE_COVERAGE: ON
ENABLE_LTO: OFF

- name: clang-18-debug-asan-ubsan
- name: clang-19-release
continue-on-error: false
node: 22
runs-on: ubuntu-24.04
BUILD_TYPE: Debug
CCOMPILER: clang-18
BUILD_TYPE: Release
CCOMPILER: clang-19
CXXCOMPILER: clang++-19
CUCUMBER_TIMEOUT: 20000
CXXCOMPILER: clang++-18
ENABLE_SANITIZER: ON
TARGET_ARCH: x86_64-asan-ubsan
OSRM_CONNECTION_RETRIES: 10
OSRM_CONNECTION_EXP_BACKOFF_COEF: 1.5
ENABLE_LTO: OFF

- name: clang-18-release
continue-on-error: false
Expand All @@ -200,30 +197,30 @@ jobs:
BUILD_TYPE: Release
CCOMPILER: clang-18
CXXCOMPILER: clang++-18
CUCUMBER_TIMEOUT: 60000
CUCUMBER_TIMEOUT: 20000
ENABLE_LTO: OFF

- name: clang-18-debug
- name: clang-18-debug-clang-tidy
continue-on-error: false
node:
node: 20
runs-on: ubuntu-24.04
BUILD_TYPE: Debug
CCOMPILER: clang-18
CXXCOMPILER: clang++-18
CUCUMBER_TIMEOUT: 60000
ENABLE_CLANG_TIDY: ON
NODE_PACKAGE_TESTS_ONLY: ON
ENABLE_LTO: OFF

- name: clang-18-debug-clang-tidy
- name: clang-18-debug-asan-ubsan
continue-on-error: false
node: 20
node: 22
runs-on: ubuntu-24.04
BUILD_TYPE: Debug
CCOMPILER: clang-18
CXXCOMPILER: clang++-18
CUCUMBER_TIMEOUT: 60000
ENABLE_CLANG_TIDY: ON
NODE_PACKAGE_TESTS_ONLY: ON
ENABLE_LTO: OFF
CXXCOMPILER: clang++-18
ENABLE_SANITIZER: ON
TARGET_ARCH: x86_64-asan-ubsan

- name: clang-17-release
continue-on-error: false
Expand All @@ -232,7 +229,7 @@ jobs:
BUILD_TYPE: Release
CCOMPILER: clang-17
CXXCOMPILER: clang++-17
CUCUMBER_TIMEOUT: 60000
CUCUMBER_TIMEOUT: 20000
ENABLE_LTO: OFF

- name: clang-16-release
Expand All @@ -242,28 +239,7 @@ jobs:
BUILD_TYPE: Release
CCOMPILER: clang-16
CXXCOMPILER: clang++-16
CUCUMBER_TIMEOUT: 60000
ENABLE_LTO: OFF

- name: conan-linux-debug-asan-ubsan
continue-on-error: false
node: 20
runs-on: ubuntu-24.04
BUILD_TYPE: Release
CCOMPILER: clang-18
CXXCOMPILER: clang++-18
ENABLE_CONAN: ON
ENABLE_SANITIZER: ON
ENABLE_LTO: OFF

- name: conan-linux-release
continue-on-error: false
node: 20
runs-on: ubuntu-24.04
BUILD_TYPE: Release
CCOMPILER: clang-18
CXXCOMPILER: clang++-18
ENABLE_CONAN: ON
CUCUMBER_TIMEOUT: 20000
ENABLE_LTO: OFF

- name: gcc-14-release
Expand All @@ -274,6 +250,7 @@ jobs:
CCOMPILER: gcc-14
CXXCOMPILER: g++-14
CXXFLAGS: '-Wno-array-bounds -Wno-uninitialized'
CUCUMBER_TIMEOUT: 20000

- name: gcc-13-release
continue-on-error: false
Expand All @@ -283,6 +260,17 @@ jobs:
CCOMPILER: gcc-13
CXXCOMPILER: g++-13
CXXFLAGS: '-Wno-array-bounds -Wno-uninitialized'
CUCUMBER_TIMEOUT: 20000

- name: gcc-13-debug-cov
continue-on-error: false
node: 22
runs-on: ubuntu-24.04
BUILD_TYPE: Debug
CCOMPILER: gcc-13
CUCUMBER_TIMEOUT: 60000
CXXCOMPILER: g++-13
ENABLE_COVERAGE: ON

- name: gcc-12-release
continue-on-error: false
Expand All @@ -292,6 +280,30 @@ jobs:
CCOMPILER: gcc-12
CXXCOMPILER: g++-12
CXXFLAGS: '-Wno-array-bounds -Wno-uninitialized'
CUCUMBER_TIMEOUT: 20000

- name: conan-linux-release
continue-on-error: false
node: 20
runs-on: ubuntu-24.04
BUILD_TYPE: Release
CCOMPILER: clang-18
CXXCOMPILER: clang++-18
CUCUMBER_TIMEOUT: 20000
ENABLE_CONAN: ON
ENABLE_LTO: OFF

- name: conan-linux-debug-asan-ubsan
continue-on-error: false
node: 20
runs-on: ubuntu-24.04
BUILD_TYPE: Release
CCOMPILER: clang-18
CXXCOMPILER: clang++-18
CUCUMBER_TIMEOUT: 60000
ENABLE_CONAN: ON
ENABLE_SANITIZER: ON
ENABLE_LTO: OFF

- name: conan-linux-release-node
build_node_package: true
Expand All @@ -301,6 +313,7 @@ jobs:
BUILD_TYPE: Release
CCOMPILER: clang-16
CXXCOMPILER: clang++-16
CUCUMBER_TIMEOUT: 20000
ENABLE_CONAN: ON
NODE_PACKAGE_TESTS_ONLY: ON

Expand All @@ -312,30 +325,31 @@ jobs:
BUILD_TYPE: Debug
CCOMPILER: clang-16
CXXCOMPILER: clang++-16
CUCUMBER_TIMEOUT: 60000
ENABLE_CONAN: ON
NODE_PACKAGE_TESTS_ONLY: ON

- name: conan-macos-x64-release-node
build_node_package: true
continue-on-error: true
node: 22
runs-on: macos-13 # x86_64
runs-on: macos-15-intel
BUILD_TYPE: Release
CCOMPILER: clang
CXXCOMPILER: clang++
CUCUMBER_TIMEOUT: 60000
CUCUMBER_TIMEOUT: 20000
ENABLE_ASSERTIONS: ON
ENABLE_CONAN: ON

- name: conan-macos-arm64-release-node
build_node_package: true
continue-on-error: true
node: 22
runs-on: macos-15 # arm64
runs-on: macos-15 # arm64
BUILD_TYPE: Release
CCOMPILER: clang
CXXCOMPILER: clang++
CUCUMBER_TIMEOUT: 60000
CUCUMBER_TIMEOUT: 20000
ENABLE_ASSERTIONS: ON
ENABLE_CONAN: ON

Expand Down Expand Up @@ -419,7 +433,7 @@ jobs:
fi
# See: https://github.com/actions/toolkit/issues/946#issuecomment-1590016041
# We need it to be able to access system folders while restoring cached Boost below
- name: Give tar root ownership
- name: Give tar root ownership
if: runner.os == 'Linux' && matrix.ENABLE_CONAN != 'ON'
run: sudo chown root /bin/tar && sudo chmod u+s /bin/tar

Expand All @@ -429,7 +443,7 @@ jobs:
id: install-boost
with:
boost_version: 1.85.0

- name: Install dev dependencies
run: |
# workaround for issue that GitHub Actions seems to not adding it to PATH after https://github.com/actions/runner-images/pull/6499
Expand All @@ -438,20 +452,21 @@ jobs:
echo "/Library/Frameworks/Python.framework/Versions/Current/bin" >> $GITHUB_PATH
fi

# ccache
# Update package list
if [[ "${RUNNER_OS}" == "Linux" || "${ENABLE_CONAN}" != "ON" ]]; then
sudo apt-get update -y
fi

# Install compiler and ccache
if [[ "${RUNNER_OS}" == "Linux" ]]; then
sudo apt-get update -y && sudo apt-get install ccache
sudo apt-get install -y ${CCOMPILER} ${CXXCOMPILER} ccache
elif [[ "${RUNNER_OS}" == "macOS" ]]; then
brew install ccache
fi

# Linux dev packages
if [ "${ENABLE_CONAN}" != "ON" ]; then
sudo apt-get update -y
if [[ "${ENABLE_CONAN}" != "ON" ]]; then
sudo apt-get install -y libbz2-dev libxml2-dev libzip-dev liblua5.2-dev
if [[ "${CCOMPILER}" != clang-* ]]; then
sudo apt-get install -y ${CXXCOMPILER}
fi
if [[ "${ENABLE_COVERAGE}" == "ON" ]]; then
sudo apt-get install -y lcov
fi
Expand Down Expand Up @@ -577,7 +592,7 @@ jobs:
uses: actions/upload-artifact@v4
if: failure()
with:
name: logs
name: ${{ matrix.name }}-test-logs
path: test/logs/

- name: Build Node package
Expand Down
Loading
Loading