-
Notifications
You must be signed in to change notification settings - Fork 259
Update to MUI 7 #4139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to MUI 7 #4139
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4139 +/- ##
==========================================
- Coverage 94.91% 94.91% -0.01%
==========================================
Files 324 324
Lines 16147 16142 -5
Branches 2533 2531 -2
==========================================
- Hits 15326 15321 -5
Misses 816 816
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not an entire review, just wanted to leave this here for them moment.
(Thanks for figuring out a solution.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, I found no issues.
I was also able to use this in the share, download and image-tools plugins and had no trouble with tests or builds.
@lutzhelm when you reviewed this yesterday did you still encountering the centering issues? I cannot reproduce them. |
@marlo-longley The "Show collection" button still appears aligned to the left for me. I also had a colleague check the preview with Chrome on Windows - same behavior. |
@dnoneill I added a new commit to address the ManifestItem input width issue. I was seeing the issue too (thanks for catching it). But I understand that Lutz was never able to see it. |
@lutzhelm I addressed all the design issues in the checklist. Thanks for your help earlier today. |
Thanks @marlo-longley, I can confirm that ManifestList and ManifestListItemError look good now, as well as the iiif resource input. However, the "Show Collection" button still appears aligned to the left for me. |
@lutzhelm thanks for catching that. It should be fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @marlo-longley, I'm sorry this took so long, but I noticed some differences between the stable version and this branch that should probably be addressed at some point - and then I got caught in a lot of other things.
Basically, the appearance on small screens is difference. In previous versions, some elements had been moved to a second Grid row. I added some notes about the IIIF resource input field, but it is similar for the ManifestListItem and the ManifestListItemError - I just did not find the time to look into this more thoroughly.
I'd be fine if these issues would fixed later.
@lutzhelm I addressed most of your concerns about small screens. Thanks for the continued reviews. Here is how it looks now. ![]() ![]() |
Thanks, @marlo-longley, it all looks way better now. I'll take another look at the code tomorrow to complete the review. I'd be fine with merging this PR with or without he offset for the resource input button grids. |
This was mostly created using MUI's codemods.
The
Grid2
component has moved back into theGrid
namespace. That is the biggest change.(for testing purposes, also included is @lutzhelm's syntax for externalizing peer dependencies but I can slice this out into another PR.)
Visually, the changes seem to have no impact, but of course more eyes are better!
I am interested in this upgrade because of the solution for better ESM support: mui/material-ui#45495. This will fix some issues reported during plugin integration such as #4136
If this is approved and merged and we cut a new alpha release, I have PRs drafted locally for several plugins to support this change. And some like
image-tools
seem to require zero changes to support 7.