Skip to content

Move to eslint 9 and remove airbnb eslint plugin #4140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marlo-longley
Copy link
Member

@marlo-longley marlo-longley commented Apr 11, 2025

Putting this up here as a thought...
This PR will quickly become stale / need rebase because it touches almost every single file

Mostly the changes are due to reformatting by eslint --fix
The files to look closest at are probably package.json and eslint.config.mjs
I was having trouble with the RTL no-node-access rule for our tests, so I temporarily disabled it. Which is not ideal.

I don't know if people felt strongly about the airbnb syntax style. I did research into what people were replacing that library with, and found that eslint:recommended combined with prettier were a solid combination. Open to ideas and feedback.

Copy link

codecov bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 89.07104% with 100 lines in your changes missing coverage. Please review.

Project coverage is 94.84%. Comparing base (48ca7e0) to head (1dce918).

Files with missing lines Patch % Lines
src/containers/WindowSideBarCollectionPanel.js 0.00% 18 Missing ⚠️
scripts/i18n-lint.js 0.00% 16 Missing ⚠️
src/lib/CanvasAnnotationDisplay.js 6.25% 15 Missing ⚠️
src/containers/WindowSideBarCanvasPanel.js 57.89% 8 Missing ⚠️
scripts/container-lint.js 0.00% 6 Missing ⚠️
src/containers/GalleryViewThumbnail.js 57.14% 6 Missing ⚠️
src/containers/IIIFAuthentication.js 62.50% 5 Missing and 1 partial ⚠️
src/containers/AudioViewer.js 33.33% 4 Missing ⚠️
src/containers/VideoViewer.js 33.33% 4 Missing ⚠️
src/containers/ChangeThemeDialog.js 33.33% 2 Missing ⚠️
... and 14 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4140      +/-   ##
==========================================
- Coverage   94.91%   94.84%   -0.08%     
==========================================
  Files         324      323       -1     
  Lines       16147    16640     +493     
  Branches     2533     2608      +75     
==========================================
+ Hits        15326    15782     +456     
- Misses        816      854      +38     
+ Partials        5        4       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant