Skip to content

Conversation

@marlo-longley
Copy link
Member

@marlo-longley marlo-longley commented Nov 19, 2025

See #4207

  • Allow config.fallbackImage to be set, optionally.
  • Provide a default fallbackImage that can be used if the setting is uncommented.

This is more of a proposal and will need discussion about design and implementation. But it does work!

Using provided default config.fallbackImage (this could use designer input):
Screenshot 2025-11-19 at 10 36 50 AM

With config.fallbackImage unset (improvement: maintains thumbnail size as requested in #4207):
Screenshot 2025-11-19 at 10 37 04 AM

This also works in the gallery view:
Screenshot 2025-11-19 at 10 53 38 AM

@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

❌ Patch coverage is 89.15663% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.1%. Comparing base (5af3981) to head (cbcefb8).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/components/OpenSeadragonTileSource.jsx 74.3% 9 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #4211     +/-   ##
=======================================
- Coverage   95.1%   95.1%   -0.0%     
=======================================
  Files        326     328      +2     
  Lines      16192   16252     +60     
  Branches    2546    2560     +14     
=======================================
+ Hits       15391   15442     +51     
- Misses       796     805      +9     
  Partials       5       5             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Needs Discussion

Development

Successfully merging this pull request may close these issues.

2 participants