Do not filter annotation motivations by default #4218
+85
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to address #4209, based on the discussion in the 11/20/2025 Mirador community call. During that call I understood that we wanted to stop filtering annotation motivations by default. This PR achieves that while leaving open the option of filtering by motivation if desired.
This is a potentially a breaking change in the case of a blank
filteredMotivationsarray in settings. Before this PR, no annotations would be rendered in that case. But in the case that you've added values to this array, the behavior will remain the same. Given that the default setting previously included values, I don't think many people would be operating with an empty array in the wild.There is probably a lot of history behind this filter, but my knowledge is recent. Open to other proposals.