Skip to content

convert_ids_to_logits() does not work with single-channel IDs#223

Merged
ATATC merged 17 commits into
mainfrom
222
Feb 23, 2026
Merged

convert_ids_to_logits() does not work with single-channel IDs#223
ATATC merged 17 commits into
mainfrom
222

Conversation

@ATATC
Copy link
Copy Markdown
Contributor

@ATATC ATATC commented Feb 19, 2026

See #222.

@ATATC ATATC added this to the 1.2.x milestone Feb 19, 2026
@ATATC ATATC requested a review from perctrix February 19, 2026 06:06
@ATATC ATATC self-assigned this Feb 19, 2026
@ATATC ATATC added bug Something isn't working todo New task or assignment labels Feb 19, 2026
@ATATC ATATC linked an issue Feb 19, 2026 that may be closed by this pull request
convert_ids_to_logits() does not work with single-channel IDs #222
Closed
@chatgpt-codex-connector
Copy link
Copy Markdown

chatgpt-codex-connector Bot commented Feb 19, 2026

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

perctrix
perctrix reviewed Feb 19, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@perctrix perctrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Input validation for convert_ids_to_logits was removed in this PR. The old code checked ids.dtype != torch.int or ids.min() < 0. Without this, passing float tensors or negative values will silently produce incorrect results. Consider keeping at least the value range check.

perctrix
perctrix previously approved these changes Feb 19, 2026
View reviewed changes
perctrix
perctrix previously approved these changes Feb 20, 2026
View reviewed changes
ATATC added 4 commits February 20, 2026 12:48
@ATATC
Added order parameter to JointTransform for configurable transfor…
0710f5a 
…m application sequence. (#222)
@ATATC
Refactored JointTransform to use Literal-based type hints for `or…
e9cd384 
…der` to enhance type safety. (#222)
@ATATC
Refactored sanity_check logic into a dedicated method `sanity_check…
5fabd42 
…` in `training.py` for improved modularity and code reuse. (#222)
@ATATC
Refactored sanity_check to accept template_model as a parameter a…
d5005eb 
…nd adjusted its usage in `training.py` for improved flexibility and clarity. (#222)
@ATATC ATATC merged commit 1732af2 into main Feb 23, 2026
3 checks passed
@ATATC ATATC deleted the 222 branch February 23, 2026 02:29
ATATC added a commit that referenced this pull request Mar 6, 2026
@ATATC
Docs. (#223)
7a2d4e8
@ATATC
Copy link
Copy Markdown
Contributor Author

ATATC commented Mar 6, 2026

Sorry I did not mean to mention this PR, it should be #233.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@perctrix perctrix perctrix approved these changes

Assignees

@ATATC ATATC

Labels

bug Something isn't working todo New task or assignment

Projects

None yet

Milestone

1.2.x

Development

Successfully merging this pull request may close these issues.

convert_ids_to_logits() does not work with single-channel IDs

2 participants

@ATATC @perctrix