Skip to content

German accent update - #1358

Merged
feistyfedora merged 14 commits into
ProjectOmu:masterfrom
starsoda743:germanaccentupdate
Sep 3, 2026
Merged

German accent update#1358
feistyfedora merged 14 commits into
ProjectOmu:masterfrom
starsoda743:germanaccentupdate

Conversation

@starsoda743

@starsoda743 starsoda743 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

About the PR

Updated the word replacements for the German accent, containing more words commonly used during play and some corrections.
Also, removed the random umlauts because they don't make sense.

Why / Balance

The current word replacement list for German contains a lot of words that rarely come up in play, while also missing many words that are likely to come up. I think it's disappointing.
This change shouldn't affect balancing.

Technical details

A new word replacement list is created at Resources/Locale/en-US/_Omu/accent/german.ftl. Resources/Prototypes/Accents/word_replacements.yml is updated to account for the new replacements and corrections.

Media

German_accent_demo

Requirements

  • I have read and am following the Pull Request and Changelog Guidelines.
  • I have added media to this PR or it does not require an ingame showcase.
  • I have read and agree to the Contributor License Agreement.

Changelog

🆑 asterisksoda

  • tweak: Updated the word replacement list for the German accent; it now contains more common words.
  • remove: Removed random umlauts from the German accent.

@github-actions github-actions Bot added S: Untriaged Has not been set a status; currently not labeled. Changes: No C# Purely YAML/non-C#. labels Aug 5, 2026
@DuskTheSnep

Copy link
Copy Markdown
Contributor

did you check to make sure this worked ingame?
also since youre editing the Resources/Prototypes/Accents/word_replacements.yml in a non omu namespace, you'll need to add a "# Omu" or "# Omustation" comment to every new line added, and comment out the old ones instead of just deleting them ((also with an omu comment appended))

@Toaster-Box Toaster-Box added S: Needs Changes Changes/Concerns have been brought up and should be made before review. Priority: Low This isn't an immediate concern. A: Chat Area: Chat-related features and changes, most likely technical and removed S: Untriaged Has not been set a status; currently not labeled. labels Aug 6, 2026
@Toaster-Box

Copy link
Copy Markdown
Contributor

yeah some media showing it working would be nice here
just show a before and after changed message in chat

@starsoda743

Copy link
Copy Markdown
Contributor Author

demonstration that it works:
German_accent_demo

i'll get onto adding comments in word_replacements.yml now

@starsoda743

starsoda743 commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

there we go

@feistyfedora

Copy link
Copy Markdown
Contributor

demonstration that it works: German_accent_demo

i'll get onto adding comments in word_replacements.yml now

Put this image in the PR body under media.

@starsoda743

Copy link
Copy Markdown
Contributor Author

Put this image in the PR body under media

done!

@Toaster-Box Toaster-Box added S: Needs Review Needs review by a maintainer. and removed S: Needs Changes Changes/Concerns have been brought up and should be made before review. labels Aug 15, 2026
@starsoda743

Copy link
Copy Markdown
Contributor Author

can confirm this still works after the upstream merge

@Thesia000 Thesia000 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just FTL ther is no need to move the old stuff to the FTL file in omu, this will be a pain for upstream

@github-actions github-actions Bot removed the S: Needs Review Needs review by a maintainer. label Aug 24, 2026
@starsoda743
starsoda743 requested a review from Thesia000 August 24, 2026 13:26
@github-actions github-actions Bot added the S: Needs Review Needs review by a maintainer. label Aug 24, 2026

@PhosphateWithManyOs PhosphateWithManyOs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

me when I'm in an argument and call someone accent-german-words-Omu-new-replace-23 instead of arschloch.

(this is a joke, it looks fine)

@github-actions github-actions Bot added the S: Needs Second Approval Approved by another maintainer, just needs one more to check it. label Aug 27, 2026

@feistyfedora feistyfedora left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAML looks fine

@github-actions github-actions Bot added S: Approved This PR has been approved. and removed S: Needs Review Needs review by a maintainer. S: Needs Second Approval Approved by another maintainer, just needs one more to check it. labels Aug 28, 2026
Comment thread Resources/Prototypes/Accents/word_replacements.yml Outdated
@github-actions github-actions Bot added S: Needs Review Needs review by a maintainer. S: Needs Second Approval Approved by another maintainer, just needs one more to check it. and removed S: Approved This PR has been approved. labels Aug 30, 2026

@feistyfedora feistyfedora left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove diacritics on german replacement words pls

@feistyfedora

Copy link
Copy Markdown
Contributor

Remove diacritics on german replacement words pls

The random ones I mean

@starsoda743

Copy link
Copy Markdown
Contributor Author

remove random diacritics

with pleasure, they were bothering me too

@feistyfedora feistyfedora left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omu comments last time I swear

Comment thread Resources/Prototypes/Accents/word_replacements.yml Outdated
Comment thread Resources/Prototypes/Accents/word_replacements.yml Outdated

@feistyfedora feistyfedora left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@github-actions github-actions Bot added S: Approved This PR has been approved. and removed S: Needs Review Needs review by a maintainer. S: Needs Second Approval Approved by another maintainer, just needs one more to check it. labels Sep 2, 2026
@feistyfedora
feistyfedora merged commit bde0e0a into ProjectOmu:master Sep 3, 2026
14 checks passed
OmuStationBot added a commit that referenced this pull request Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A: Chat Area: Chat-related features and changes, most likely technical Changes: No C# Purely YAML/non-C#. Priority: Low This isn't an immediate concern. S: Approved This PR has been approved. size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants