Skip to content

No node in conda environment#594

Merged
brian-rose merged 1 commit intoProjectPythia:mainfrom
brian-rose:remove-node
Jan 20, 2026
Merged

No node in conda environment#594
brian-rose merged 1 commit intoProjectPythia:mainfrom
brian-rose:remove-node

Conversation

@brian-rose
Copy link
Copy Markdown
Member

Potentially closes #593 and gets builds working again

@brian-rose brian-rose requested a review from a team as a code owner January 20, 2026 16:56
@brian-rose brian-rose requested review from mgrover1 and r-ford and removed request for a team January 20, 2026 16:56
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 20, 2026

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 683ce98
✅ Deployment Preview URL: https://ProjectPythia.github.io/pythia-foundations/_preview/594

Copy link
Copy Markdown
Contributor

@kafitzgerald kafitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working again with this change.

Did you figure out what was causing the older version of node to get installed? Just curious in case this needs to be updated elsewhere.

For instance, I think we have this specified in all or most of the cookbook envs. Though interestingly at least this one seems fine: https://github.com/ProjectPythia/advanced-viz-cookbook/actions/workflows/nightly-build.yaml

@brian-rose
Copy link
Copy Markdown
Member Author

@kafitzgerald I'm not sure. I checked the Cookbook Template repo. nodejs is not listed in its environment file, but does get installed (presumably as a conda-forge-defined dependency of mystmd, e.g. here in this build log.

@brian-rose
Copy link
Copy Markdown
Member Author

In this most recent failed build log for Foundations, a much older version of nodejs was installed (12.4.0)

Different versions of nodejs and mystmd seem to be installed in different cookbook builds, and I'm currently very confused about it.

@brian-rose
Copy link
Copy Markdown
Member Author

I'll merge this now so the broken builds aren't holding up other work on Foundations, but it would be good to understand the issue better.

@brian-rose brian-rose merged commit 3ba5a0a into ProjectPythia:main Jan 20, 2026
3 checks passed
@brian-rose brian-rose deleted the remove-node branch January 20, 2026 18:20
github-actions bot pushed a commit that referenced this pull request Jan 20, 2026
@brian-rose brian-rose mentioned this pull request Jan 20, 2026
@kafitzgerald
Copy link
Copy Markdown
Contributor

Yeah, I'm not quite sure what is going on either w/ the builds on this repo (the specification of nodejs isn't needed anymore, but also shouldn't have been breaking anything).

This seems like a reasonable change though and I did verify that mystmd does have an explicit nodejs dependency on conda-forge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

myst build is failing

2 participants