Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. |
|
Note that our current link checker passes with broken links, but I was playing with over in #608, and these fixes are needed to pass the link checker with that option. |
kafitzgerald
left a comment
kafitzgerald
left a comment
There was a problem hiding this comment.
Looks good!
If you wanted to, we could leverage the MyST functionality for linking to Sphinx-based documentation for stuff like the datetime.strptime() link (see here: https://mystmd.org/guide/external-references#intersphinx). Might be easier / better to wait on this though and implement where relevant in a new PR.
|
@kafitzgerald I took a quick dive through some of this cross-referencing. I found it useful to update (and hopefully future-proof) a bunch of the links in the Xarray intro notebook. On the other hand, finding the right Sphinx references for the Python standard library stuff I found to be complicated. Dropping that for now but I'll open an issue about making wider use of this capability as a future enhancement. |
brian-rose
requested review from
jukent,
kafitzgerald and
ktyle
and removed request for
a team
|
Not sure what's going on with the link checker and the pangeo.io site. |
Probably a random glitch. Anyway there's nothing wrong with the link itself so I will merge. |
2 participants
This PR fixes some broken links.
One of the current issues is with old links to descriptions of the NLDN lightning dataset. It seems that the page
https://ghrc.nsstc.nasa.gov/uso/ds_docs/vaiconus/vaiconus_dataset.html no longer exists, and the only useful links I could find for this dataset point to the Vaisala website.