Avoid evaluating void variables#737
Open
haselwarter wants to merge 1 commit intoProofGeneral:masterfrom
Open
Conversation
The last `unless` case of `unicode-tokens-copy-configuration-variables` tries to evaluate variables which may be undefined via `symbol-value`, which leads to an error. This commit adds a check to make sure the variables are only accessed if bound.
Contributor
|
Hi. thanks for the PR. Sorry for the delay... Do we really want this? If one uses @cpitclaudel and @hendriktews what do you think? |
Contributor
|
Any idea about this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last
unlesscase ofunicode-tokens-copy-configuration-variablestries to evaluate variables which may be undefined viasymbol-value, which leads to an error. This commit adds a check to make sure the variables are only accessed if bound.How this ever worked without errors I don't know...