Open
Conversation
sinistersnare
force-pushed
the
feature/psp3
branch
3 times, most recently
from
1f48935 to
28f9841
Compare
sinistersnare
force-pushed
the
feature/psp3
branch
2 times, most recently
from
a963e08 to
a544d63
Compare
Signed-off-by: Will Rieger <will.r.rieger@gmail.com>
Change Time::MIN to Time::MIN_VALUE to match DateTime
| self._limit = limit | ||
| self._localize = localize | ||
|
|
||
| # TODO: we do not want 1 server per table, make a Client param? |
There was a problem hiding this comment.
It does "feel" wrong to me creating a new server per table, but I am curious how it would be a problem. Does a server have lots of overhead? Does a collection of tables in the same server share more resources than the same collection of tables on different servers? Are there any potential advantages to isolating a table per server?
sinistersnare
force-pushed
the
feature/psp3
branch
3 times, most recently
from
7363855 to
1c58bfb
Compare
Signed-off-by: Davis Silverman <davis@thedav.is>
sinistersnare
force-pushed
the
feature/psp3
branch
from
1c58bfb to
b104319
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specific modifications done to CSP for this change:
csp/dataframe.py: Theto_perspectivefunction now must take aClientobject to construct theTable.csp/adapters/perspective.py: The use ofPerspectiveManagerwas changed to use of the newClient/Serverclasses.csp/impl/pandas_perspective.py: Perspective Table JSON update does not support directdateordatetimevalues now, as theses are not JSON serializable types. To work around this, the objects are directly translated to timestamp integers and sent to Perspective to be parsed into Perspective’s time types.to_dfwas rewritten to route throughPyArrow, but due to differences in how PyArrow chooses dtypes, there is some hackery around ordering of categories. We also removedto_dictandto_numpybecause they were removed in the Perspective 3.0 migration.csp/tests/impl/test_pandas_perspective.pymany tests were fixed to demonstrate changes that are needed to continue day-to-day use ofCspPerspectiveTable. Some tests were not fixed due to an outstanding Perspective bug (Unit test describing index behavior bug perspective-dev/perspective#2756).The use of PyArrow to underly Perspective’s DataFrame support leads to some semantic changes. PyArrow is much more eager to set columns to
CategoricalDtypeinstead ofStringDtype. It also has different behavior regarding category ordering, and perhaps others still not uncovered after fixing the tests.